HeapStoreOptimization: Migrate from invalidates to orderedBefore#8758
Draft
tlively wants to merge 6 commits into
Draft
HeapStoreOptimization: Migrate from invalidates to orderedBefore#8758tlively wants to merge 6 commits into
tlively wants to merge 6 commits into
Conversation
Replace the coarse `invalidates` check and the coarse global state check in LICM with more precise `orderedBefore` checks. This allows LICM to move memory accesses past release stores, while still correctly blocking them from moving past acquire loads. Add a lit test to verify the asymmetrical reordering behavior with release/acquire atomics on shared memory/GC structs.
Replace the coarse `invalidates` check in `LocalCSE` with `orderedBefore`. This allows `LocalCSE` to reuse expression values across release stores, while still correctly blocking reuse across acquire loads. Add a lit test to verify the asymmetrical reordering behavior with release/acquire atomics on shared GC structs and Wasm memory.
Replace the coarse `invalidates` check in `CodePushing` with `orderedBefore`. This allows `CodePushing` to push expressions (like GC reads) past acquire loads, while still correctly blocking them from being pushed past release stores. Add a lit test to verify the asymmetrical reordering behavior with release/acquire atomics on shared GC structs and Wasm memory.
Replace the coarse `invalidates` check in `HeapStoreOptimization` with `orderedBefore`. This allows `HeapStoreOptimization` to optimize heap stores across release stores (e.g., moving a GC read before a release store), while still correctly blocking them from being moved before acquire loads. Added a lit test to verify the asymmetrical reordering behavior with release/acquire atomics on shared GC structs and Wasm memory. TAG=agy
tlively
changed the title
Member
Author
|
Oops, this was uploaded with an incorrect name. Fixed now. |
kripken
reviewed
May 22, 2026
Member
There was a problem hiding this comment.
The title still seems wrong, this is not HeapStoreOptimization?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the coarse
invalidatescheck inHeapStoreOptimizationwithorderedBefore. This allowsHeapStoreOptimizationto optimize heap stores across release stores (e.g., moving a GC read before a release store), while still correctly blocking them from being moved before acquire loads.Added a lit test to verify the asymmetrical reordering behavior with release/acquire atomics on shared GC structs and Wasm memory.
TAG=agy