[wasm-split] Generate fillers in MVP + --no-placenolders#8759
Merged
Conversation
When --no-placeholder is given and reference-types is disabled, we cannot fill the table with `ref.nulls`. Previously we were generating `ref.null`s anyway, creating invalid modules. This generates a dummy function in place of `ref.null`s.
aheejin
changed the title
tlively
reviewed
May 22, 2026
Member
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
Perhaps "filler" instead of "dummy" for more inclusive language. Other than that, LGTM.
aheejin
changed the title
tlively
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When --no-placeholder is given and reference-types is disabled, we cannot fill the table with
ref.nulls. Previously we were generatingref.nulls anyway, creating invalid modules. This generates filler functions in place ofref.nulls.