Skip to content

Add multi-threaded tests for acquire/release atomics #8999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevenfontanella merged 5 commits into from
Aug 15, 2026
Merged

Add multi-threaded tests for acquire/release atomics #8999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b9ded3f
Tests for acquire/release atomics
stevenfontanella Jul 30, 2026
186fde7
Rename test script
stevenfontanella Aug 13, 2026
0df3bff
Write to memory instead of using shared globals, which aren't supported
stevenfontanella Aug 13, 2026
430ad10
Add some comments
stevenfontanella Aug 14, 2026
fcbdd97
Change some variable names in comments
stevenfontanella Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...ts/test/relaxed_atomic_execution_tests.py → ...cquire_release_atomics_execution_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,8 @@
(func (export "i64.atomic.rmw32.cmpxchg_u") (param $addr i32) (param $expected i64) (param $value i64) (result i64) (i64.atomic.rmw32.cmpxchg_u acqrel (local.get $addr) (local.get $expected) (local.get $value)))

(func (export "atomic.fence") (atomic.fence acqrel))

Comment thread
stevenfontanella marked this conversation as resolved.
(func (export "pause") (pause))
)

;; *.atomic.load*
Expand Down Expand Up @@ -395,6 +397,10 @@

(invoke "atomic.fence")

;; pause

(invoke "pause")


;; unaligned accesses

Expand Down
2 changes: 1 addition & 1 deletion scripts/test/generate_atomic_spec_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from dataclasses import dataclass
from enum import Enum

from relaxed_atomic_execution_tests import acqrel_execution_tests
from acquire_release_atomics_execution_tests import acqrel_execution_tests

# Workaround for python <3.10, escape characters can't appear in f-strings.
# Although we require 3.10 in some places, the formatter complains without this.
Expand Down
2 changes: 1 addition & 1 deletion scripts/test/support.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def to_end(j):
ret += [(chunk, [])]
elif chunk.startswith('(assert_invalid'):
continue
elif chunk.startswith(('(assert', '(invoke', '(register')) and not ignoring_assertions:
elif chunk.startswith(('(assert', '(invoke', '(register', '(thread', '(wait')) and not ignoring_assertions:
# ret may be empty if there are some asserts before the first
# module. in that case these are asserts *without* a module, which
# are valid (they may check something that doesn't refer to a module
Expand Down
6 changes: 6 additions & 0 deletions test/spec/relaxed-atomics.wast → test/spec/acquire-release-atomics/basic.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5348,6 +5348,8 @@
(func (export "i64.atomic.rmw32.cmpxchg_u") (param $addr i32) (param $expected i64) (param $value i64) (result i64) (i64.atomic.rmw32.cmpxchg_u acqrel (local.get $addr) (local.get $expected) (local.get $value)))

(func (export "atomic.fence") (atomic.fence acqrel))

(func (export "pause") (pause))
)

;; *.atomic.load*
Expand Down Expand Up @@ -5663,6 +5665,10 @@

(invoke "atomic.fence")

;; pause

(invoke "pause")


;; unaligned accesses

Expand Down
Loading
Loading