Build/Test Tools: Output relevant URLs in GitHub Actions logs by ArkaPrabhaChowdhury · Pull Request #11223 · WordPress/wordpress-develop

ArkaPrabhaChowdhury · 2026-03-11T07:20:15Z

I have added core.notice() logging to output the relevant URLs for Trac tickets, PRs, and SVN logs to the workflows mentioned in #64299.

Because these workflows run on pull_request_target and workflow_run events, GitHub enforces running the trunk version of the workflow files, so I was unable to test the live output of these changes in this PR.

Let me know if you need any adjustments!

Use of AI Tools

Tools: Google Antigravity for basic suggestions and confirmation. Final implementation were reviewed and edited by me.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Trac ticket: https://core.trac.wordpress.org/ticket/64299

Use of AI Tools

AI assistance: Yes
Tool(s): OpenAI Codex
Model(s): GPT-5
Used for: Reviewing the Trac ticket and relevant code, helping with the initial implementation and regression-test approach, and assisting with validation and PR-description drafting. The final implementation, tests, validation results, and description were reviewed and accepted by me.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

github-actions · 2026-03-11T07:20:24Z

Hi @ArkaPrabhaChowdhury! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

github-actions · 2026-03-11T07:31:49Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props arkaprabhachowdhury, adrianmoldovanwp, desrosj, lancewillett.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

desrosj · 2026-03-11T16:26:45Z

Assigning myself to take a look.

lancewillett · 2026-09-08T16:15:52Z

Thanks for this. 3 changes would make it ready for review again:

Drop the commit-built-file-changes.yml hunk. That workflow was removed from trunk in r63315, which is why the PR now shows a merge conflict.
Reuse the existing variables in reusable-cleanup-pull-requests.yml. On trunk, the script there already receives FIXED_LIST and SVN_REVISION_NUMBER through env: and reads them into fixedList and svnRevisionNumber. Using those instead of expanding ${{ steps.trac-tickets.outputs.fixed_list }} and ${{ steps.git-svn-id.outputs.svn_revision_number }} inline will clear the two open zizmor "code injection via template expansion" alerts.
Pin actions/github-script to the version already in use. The new steps pin v8.0.0; every existing step in these files is on v9.0.0 (3a2844b7e9c422d3c10d287c895573f7108da1b3).

Once those are in and the branch is rebased on trunk, ping us and we will take another look.

ArkaPrabhaChowdhury · 2026-09-09T08:13:57Z

Hi @lancewillett,

Thanks for the feedback.

I have addressed the issues. Please do take another look. Thanks!

adimoldovan

Thanks @ArkaPrabhaChowdhury, the three earlier points are all addressed. A few more, all about the log lines themselves.

adimoldovan · 2026-09-09T15:50:19Z

+
            // Update all matched pull requests.
            for (const prNumber of prNumbers) {
+              core.notice(`Closed pull request: https://github.com/${context.repo.owner}/${context.repo.repo}/pull/${prNumber}`);


This says "Closed" before the comment and close calls below run. If either call fails, the PR stays open and the run summary still says it was closed. Move the notice after pulls.update, or at least make the wording honest:

Suggested change

core.notice(`Closed pull request: https://github.com/${context.repo.owner}/${context.repo.repo}/pull/${prNumber}`);

core.notice(`Closing pull request: https://github.com/${context.repo.owner}/${context.repo.repo}/pull/${prNumber}`);

adimoldovan · 2026-09-09T15:50:19Z

+            core.notice(`Created Playground comment for pull request: https://github.com/${context.repo.owner}/${context.repo.repo}/pull/${issue_number}`);
            github.rest.issues.createComment( commentInfo );


"Created" is logged before the comment exists, and the create call is not awaited, so a failed call leaves a log that claims a comment that is not there. pr.data.html_url is already in scope, so the URL does not need to be built by hand.

Suggested change

core.notice(`Created Playground comment for pull request: https://github.com/${context.repo.owner}/${context.repo.repo}/pull/${issue_number}`);

github.rest.issues.createComment( commentInfo );

await github.rest.issues.createComment( commentInfo );

core.notice( `Created Playground comment for pull request: ${ pr.data.html_url }` );

adimoldovan · 2026-09-09T15:50:19Z

+              core.notice(`Created missing Trac ticket comment for pull request: https://github.com/${owner}/${repo}/pull/${number}`);
              github.rest.issues.createComment( {


Same problem: "Created" is logged before the create call, which is not awaited. pr.html_url is already in scope.

Suggested change

core.notice(`Created missing Trac ticket comment for pull request: https://github.com/${owner}/${repo}/pull/${number}`);

github.rest.issues.createComment( {

core.notice( `Creating missing Trac ticket comment for pull request: ${ pr.html_url }` );

await github.rest.issues.createComment( {

adimoldovan · 2026-09-09T15:50:19Z

+            for (const ticket of fixedList) {
+              core.notice(`Ticket: https://core.trac.wordpress.org/ticket/${ticket}`);
+            }
+            core.notice(`SVN changeset: https://core.trac.wordpress.org/changeset/${svnRevisionNumber}`);


These run only after the whole search loop, so a run that fails during the GraphQL search logs no ticket or changeset at all. The loop at line 60 already builds tracTicketUrl: log the ticket there, and log the changeset before the search starts.

adimoldovan · 2026-09-09T15:50:19Z

            This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.`;

+            for (const ticket of fixedList) {
+              core.notice(`Ticket: https://core.trac.wordpress.org/ticket/${ticket}`);


core.notice() makes an annotation, and GitHub shows at most 10 per step. One per ticket, one per changeset and one per closed PR in this single step means a commit that closes many PRs loses the last links from the summary. Use core.info() for the per-item lines (as pull-request-comments.yml already does) and keep one headline core.notice().

adimoldovan · 2026-09-09T15:50:19Z

            // Update all matched pull requests.
            for (const prNumber of prNumbers) {


Two small things on this loop. When no PR matches, the run says nothing, so a reader cannot tell "nothing to close" from "loop never ran". And prNumbers can hold the same PR twice when a commit fixes two tickets that one PR references, which now also repeats the notice.

Suggested change

// Update all matched pull requests.

for (const prNumber of prNumbers) {

const uniquePrNumbers = [...new Set(prNumbers)];

core.info(`Found ${uniquePrNumbers.length} pull request(s) to close.`);

// Update all matched pull requests.

for (const prNumber of uniquePrNumbers) {

adimoldovan · 2026-09-09T15:50:19Z

              return;
            }

+            core.notice(`Rerunning workflow run: ${workflow_run.data.html_url}`);


The early return still logs nothing, so a second-attempt run is green with an empty log, which is the no-context case in the ticket. The run data already has the name and branch, so log them too.

Suggested change

return;

}

core.notice(`Rerunning workflow run: ${workflow_run.data.html_url}`);

core.info(`Skipping rerun, attempt ${workflow_run.data.run_attempt}: ${workflow_run.data.html_url}`);

return;

}

core.notice(`Rerunning workflow run "${workflow_run.data.name}" on ${workflow_run.data.head_branch}: ${workflow_run.data.html_url}`);

adimoldovan · 2026-09-09T15:50:19Z

+      - name: Output PR link
+        uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0
+        with:
+          script: |
+            core.notice(`Pull request: https://github.com/${context.repo.owner}/${context.repo.repo}/pull/${context.issue.number}`);


This boots a whole Node step to echo one string. A plain run step does the same, and the event payload already has the URL for every trigger this job accepts.

Suggested change

- name: Output PR link

uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0

with:

script: |

core.notice(`Pull request: https://github.com/${context.repo.owner}/${context.repo.repo}/pull/${context.issue.number}`);

- name: Output PR link

env:

PR_URL: ${{ github.event.pull_request.html_url || github.event.issue.html_url }}

run: echo "::notice::Pull request: $PR_URL"

…#64299.

ArkaPrabhaChowdhury · 2026-09-10T09:56:07Z

Hi @adimoldovan,

Thanks for the detailed review. Helps a lot to understand the flow in-depth.

I have addressed the issues.

Thanks!

adimoldovan

Thanks for addressing all the raised issues @ArkaPrabhaChowdhury.

It looks good to land for me.

Log the workflow run, pull request, Trac ticket, and SVN changeset URLs handled by the automation workflows. Report skipped reruns and empty pull request searches, and avoid processing the same pull request more than once. Await comment creation so failures are reported and success notices reflect completed requests. Developed in: #11223 Props arkaprabhachowdhury, adrianmoldovanwp, desrosj. Fixes #64299. git-svn-id: https://develop.svn.wordpress.org/trunk@63583 602fd350-edb4-49c9-b593-d223f7449a82

github-actions · 2026-09-10T14:25:18Z

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 63583
GitHub commit: 9a2e38e

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

lancewillett · 2026-09-10T14:25:34Z

Thanks, @ArkaPrabhaChowdhury Arkaprabha, for sticking with your first wordpress-develop PR through review! 🙌 Great to see it land alongside your other Core contributions this year.

Log the workflow run, pull request, Trac ticket, and SVN changeset URLs handled by the automation workflows. Report skipped reruns and empty pull request searches, and avoid processing the same pull request more than once. Await comment creation so failures are reported and success notices reflect completed requests. Developed in: WordPress/wordpress-develop#11223 Props arkaprabhachowdhury, adrianmoldovanwp, desrosj. Fixes #64299. Built from https://develop.svn.wordpress.org/trunk@63583 git-svn-id: http://core.svn.wordpress.org/trunk@62759 1a063a9b-81f0-0310-95a4-ce76da25c4cd

ArkaPrabhaChowdhury marked this pull request as ready for review March 11, 2026 07:31

ArkaPrabhaChowdhury changed the title ~~Build/Test Tools: Output relevant URLs in GitHub Actions logs. Fixes …~~ Build/Test Tools: Output relevant URLs in GitHub Actions logs. Mar 11, 2026

desrosj self-requested a review March 11, 2026 16:26

pento force-pushed the trunk branch from 3af2d27 to 64ede28 Compare July 6, 2026 03:10

github-advanced-security Bot found potential problems Aug 16, 2026

View reviewed changes

Comment thread .github/workflows/reusable-cleanup-pull-requests.yml Fixed

Comment thread .github/workflows/reusable-cleanup-pull-requests.yml Fixed

desrosj added this to WordPress Project Build Tooling Aug 16, 2026

github-project-automation Bot moved this to Backlog in WordPress Project Build Tooling Aug 16, 2026

desrosj moved this from Backlog to In review in WordPress Project Build Tooling Aug 16, 2026

lancewillett assigned lancewillett and desrosj and unassigned lancewillett Sep 2, 2026

lancewillett self-requested a review September 8, 2026 16:13

ArkaPrabhaChowdhury force-pushed the add-actions-logging branch from 9d257a8 to 9379261 Compare September 9, 2026 08:06

lancewillett requested review from aaronjorbin, adimoldovan and lucatume September 9, 2026 14:53

adimoldovan reviewed Sep 10, 2026

View reviewed changes

ArkaPrabhaChowdhury added 3 commits September 10, 2026 15:12

Build/Test Tools: Output relevant URLs in GitHub Actions logs. Fixes …

85d054f

…#64299.

Build/Test Tools: Address workflow review feedback

4ee6117

Build/Test Tools: Address workflow review feedback

eccefd5

ArkaPrabhaChowdhury force-pushed the add-actions-logging branch from 9379261 to eccefd5 Compare September 10, 2026 09:49

adimoldovan self-requested a review September 10, 2026 13:46

adimoldovan approved these changes Sep 10, 2026

View reviewed changes

lancewillett changed the title ~~Build/Test Tools: Output relevant URLs in GitHub Actions logs.~~ Build/Test Tools: Output relevant URLs in GitHub Actions logs Sep 10, 2026

lancewillett approved these changes Sep 10, 2026

View reviewed changes

github-actions Bot closed this Sep 10, 2026

github-project-automation Bot moved this from In review to Done in WordPress Project Build Tooling Sep 10, 2026

	core.notice(`Closed pull request: https://github.com/${context.repo.owner}/${context.repo.repo}/pull/${prNumber}`);
	core.notice(`Closing pull request: https://github.com/${context.repo.owner}/${context.repo.repo}/pull/${prNumber}`);

		core.notice(`Created Playground comment for pull request: https://github.com/${context.repo.owner}/${context.repo.repo}/pull/${issue_number}`);
		github.rest.issues.createComment( commentInfo );

-            core.notice(`Created Playground comment for pull request: https://github.com/${context.repo.owner}/${context.repo.repo}/pull/${issue_number}`);
-            github.rest.issues.createComment( commentInfo );
+            await github.rest.issues.createComment( commentInfo );
+            core.notice( `Created Playground comment for pull request: ${ pr.data.html_url }` );

		core.notice(`Created missing Trac ticket comment for pull request: https://github.com/${owner}/${repo}/pull/${number}`);
		github.rest.issues.createComment( {

		// Update all matched pull requests.
		for (const prNumber of prNumbers) {

-              return;
-            }
-            core.notice(`Rerunning workflow run: ${workflow_run.data.html_url}`);
+              core.info(`Skipping rerun, attempt ${workflow_run.data.run_attempt}: ${workflow_run.data.html_url}`);
+              return;
+            }
+            core.notice(`Rerunning workflow run "${workflow_run.data.name}" on ${workflow_run.data.head_branch}: ${workflow_run.data.html_url}`);

Uh oh!

Conversation

ArkaPrabhaChowdhury commented Mar 11, 2026 • edited by lancewillett Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Use of AI Tools

Use of AI Tools

Uh oh!

github-actions Bot commented Mar 11, 2026

Uh oh!

github-actions Bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

desrosj commented Mar 11, 2026

Uh oh!

Uh oh!

Uh oh!

lancewillett commented Sep 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ArkaPrabhaChowdhury commented Sep 9, 2026

Uh oh!

adimoldovan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ArkaPrabhaChowdhury commented Sep 10, 2026

Uh oh!

adimoldovan left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 10, 2026

Uh oh!

lancewillett commented Sep 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ArkaPrabhaChowdhury commented Mar 11, 2026 •

edited by lancewillett

Loading

github-actions Bot commented Mar 11, 2026 •

edited

Loading

lancewillett commented Sep 8, 2026 •

edited

Loading