Script Loader: Avoid false entries in inline script extras - #12217
Script Loader: Avoid false entries in inline script extras#12217Sukhendu2002 wants to merge 11 commits into
Conversation
|
Hi there! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
`WP_Scripts::get_data()` returns `false` when a handle has no `before` or `after` data, and casting that to an array produced `array( false )`. The first inline script added for a handle was therefore stored after an unused `false` entry. Missing inline script data is now treated as an empty array. Developed in: #12217 Follow-up to r36633. Props vanyukov, sukhendu2002, jonsurrell, apermo. Fixes #52320. git-svn-id: https://develop.svn.wordpress.org/trunk@63579 602fd350-edb4-49c9-b593-d223f7449a82
|
Thanks @Sukhendu2002! |
`WP_Scripts::get_data()` returns `false` when a handle has no `before` or `after` data, and casting that to an array produced `array( false )`. The first inline script added for a handle was therefore stored after an unused `false` entry. Missing inline script data is now treated as an empty array. Developed in: WordPress/wordpress-develop#12217 Follow-up to r36633. Props vanyukov, sukhendu2002, jonsurrell, apermo. Fixes #52320. Built from https://develop.svn.wordpress.org/trunk@63579 git-svn-id: http://core.svn.wordpress.org/trunk@62755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Trac ticket: https://core.trac.wordpress.org/ticket/52320
What this PR does
This PR fixes an unintended
falseentry being stored inWP_Scriptsinline script data when adding the first inline script for a handle.When
WP_Scripts::get_data()returnsfalsefor missingbefore/afterdata,WP_Scripts::add_inline_script()previously cast that directly to an array, producingarray( false )before appending the real inline script.This change treats missing inline script data as an empty array before appending.
Before:
After:
Use of AI Tools
AI assistance: Yes
Tool(s): pi
Model(s): GPT-5.6
Used for: Patch review, test suggestions, and PR description drafting. final implementation and tests were reviewed and edited by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.