Use wp_rand() for security-sensitive token generation - #12285
Use wp_rand() for security-sensitive token generation#12285tanjiroK-coder wants to merge 1 commit into
Conversation
|
Hi there! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @tanjiroK-coder. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
54e8411 to
39b1a23
Compare
Trac Ticket MissingThis pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook. |
Replace remaining uses of PHP's legacy
rand()andmt_rand()functions with WordPress'swp_rand()when generating security-relevant tokens.Changes
wp-admin/includes/file.phpReplace:
with:
These values are used by the plugin/theme file editor's fatal-error scraping workflow and represent short-lived authorization tokens.
wp-includes/ms-functions.phpReplace:
with:
The generated hash is used as the confirmation token during multisite network administrator email change requests.
Rationale
WordPress core generally uses
wp_rand()for generating security-sensitive values.wp_rand()is backed by a cryptographically secure random source where available, whereasrand()andmt_rand()are not intended for security-sensitive use cases.This change improves consistency across core and ensures that all token-generation paths rely on the same secure randomness mechanism.