Skip to content

Code Quality: Annotate WP_HTML_Tag_Processor::parse_next_tag() as impure #13057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tstokes8040 wants to merge 1 commit into from
Closed

Code Quality: Annotate WP_HTML_Tag_Processor::parse_next_tag() as impure #13057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions phpstan.neon.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ includes:
- tests/phpstan/baselines/assign.propertyType.neon
- tests/phpstan/baselines/binaryOp.invalid.neon
- tests/phpstan/baselines/booleanAnd.alwaysFalse.neon
- tests/phpstan/baselines/booleanAnd.alwaysTrue.neon
- tests/phpstan/baselines/booleanAnd.leftAlwaysTrue.neon
- tests/phpstan/baselines/booleanAnd.rightAlwaysTrue.neon
- tests/phpstan/baselines/booleanNot.alwaysFalse.neon
Expand Down Expand Up @@ -80,7 +79,6 @@ includes:
- tests/phpstan/baselines/property.phpDocType.neon
- tests/phpstan/baselines/property.private.neon
- tests/phpstan/baselines/property.protected.neon
- tests/phpstan/baselines/property.unusedType.neon
- tests/phpstan/baselines/return.empty.neon
- tests/phpstan/baselines/return.missing.neon
- tests/phpstan/baselines/return.type.neon
Expand Down
2 changes: 2 additions & 0 deletions src/wp-includes/html-api/class-wp-html-tag-processor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1728,6 +1728,8 @@ private function skip_script_data(): bool {
* @ignore
*
* @return bool Whether a tag was found before the end of the document.
*
* @phpstan-impure

@westonruter westonruter Aug 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is consistent with the same which was added in 68c0f19 on the next_tag() method:

wordpress-develop/src/wp-includes/html-api/class-wp-html-tag-processor.php

Lines 895 to 899 in b84edad

* @return bool Whether a tag was matched.
*
* @phpstan-impure
*/
public function next_tag( $query = null ): bool {

*/
private function parse_next_tag(): bool {
$this->after_tag();
Expand Down
25 changes: 0 additions & 25 deletions tests/phpstan/baselines/booleanAnd.alwaysTrue.neon
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions tests/phpstan/baselines/deadCode.unreachable.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,11 +288,6 @@ parameters:
identifier: deadCode.unreachable
count: 31
path: ../../../src/wp-includes/html-api/class-wp-html-processor.php
-
message: '#^Unreachable statement \- code above always terminates\.$#'
identifier: deadCode.unreachable
count: 1
path: ../../../src/wp-includes/html-api/class-wp-html-tag-processor.php
-
message: '#^Unreachable statement \- code above always terminates\.$#'
identifier: deadCode.unreachable
Expand Down
5 changes: 0 additions & 5 deletions tests/phpstan/baselines/identical.alwaysFalse.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,6 @@ parameters:
identifier: identical.alwaysFalse
count: 1
path: ../../../src/wp-includes/html-api/class-wp-html-processor.php
-
message: '#^Strict comparison using \=\=\= between ''STATE_INCOMPLETE…'' and ''STATE_READY'' will always evaluate to false\.$#'
identifier: identical.alwaysFalse
count: 1
path: ../../../src/wp-includes/html-api/class-wp-html-tag-processor.php
-
message: '#^Strict comparison using \=\=\= between 3000000000 and 2147483647 will always evaluate to false\.$#'
identifier: identical.alwaysFalse
Expand Down
10 changes: 0 additions & 10 deletions tests/phpstan/baselines/method.unused.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,3 @@ parameters:
identifier: method.unused
count: 1
path: ../../../src/wp-includes/class-wp-script-modules.php
-
message: '#^Method WP_HTML_Tag_Processor\:\:skip_rawtext\(\) is unused\.$#'
identifier: method.unused
count: 1
path: ../../../src/wp-includes/html-api/class-wp-html-tag-processor.php
-
message: '#^Method WP_HTML_Tag_Processor\:\:skip_script_data\(\) is unused\.$#'
identifier: method.unused
count: 1
path: ../../../src/wp-includes/html-api/class-wp-html-tag-processor.php
15 changes: 0 additions & 15 deletions tests/phpstan/baselines/notIdentical.alwaysTrue.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,21 +38,6 @@ parameters:
identifier: notIdentical.alwaysTrue
count: 1
path: ../../../src/wp-includes/functions.php
-
message: '#^Strict comparison using \!\=\= between ''STATE_COMPLETE'' and ''STATE_READY'' will always evaluate to true\.$#'
identifier: notIdentical.alwaysTrue
count: 1
path: ../../../src/wp-includes/html-api/class-wp-html-tag-processor.php
-
message: '#^Strict comparison using \!\=\= between ''STATE_INCOMPLETE…'' and ''STATE_READY'' will always evaluate to true\.$#'
identifier: notIdentical.alwaysTrue
count: 1
path: ../../../src/wp-includes/html-api/class-wp-html-tag-processor.php
-
message: '#^Strict comparison using \!\=\= between ''STATE_MATCHED_TAG'' and ''STATE_READY'' will always evaluate to true\.$#'
identifier: notIdentical.alwaysTrue
count: 1
path: ../../../src/wp-includes/html-api/class-wp-html-tag-processor.php
-
message: '#^Strict comparison using \!\=\= between 0 and int\<min, \-1\>\|int\<1, max\> will always evaluate to true\.$#'
identifier: notIdentical.alwaysTrue
Expand Down
25 changes: 0 additions & 25 deletions tests/phpstan/baselines/property.unusedType.neon
View file
Open in desktop

This file was deleted.

Loading