Skip to content

Tests: Restore themes after block tests - #13205

Closed
sirreal wants to merge 4 commits into
WordPress:trunkfrom
sirreal:agent/test-order-blocks-isolation
Closed

Tests: Restore themes after block tests#13205
sirreal wants to merge 4 commits into
WordPress:trunkfrom
sirreal:agent/test-order-blocks-isolation

Conversation

@sirreal

@sirreal sirreal commented Aug 20, 2026

Copy link
Copy Markdown
Member

Summary

  • Restores the incoming stylesheet after block-template and editor fixtures switch themes.
  • Applies the same teardown discipline to the remaining blocks-group fixtures that switch themes.
  • Prevents stale Theme JSON state from changing later block rendering.
  • Keeps the changes confined to PHPUnit tests and fixtures.

Verification

  • Minimized two independent contaminators of the block-rendering columns case and replayed both original failing seeds.
  • 100 consecutive fresh randomized blocks-group runs passed on the combined campaign branch after the complete theme-switch audit; each completed 1,080 tests and 2,825 assertions. Both relevant patch IDs and all seven changed file trees match this isolated branch.
  • Seeds 1789029001 through 1789029100 all exited cleanly.
  • PHP syntax checks and git diff --check passed.

Trac: https://core.trac.wordpress.org/ticket/65893

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@lancewillett

Copy link
Copy Markdown
Member

Updated this branch with current trunk and fixed the PHPCS assignment-alignment warning in wpBlockPatternsRegistry.php.

Validation: targeted PHPCS passes. The focused PHPUnit file could not run because the local test configuration file is not present.

@lancewillett
lancewillett marked this pull request as ready for review September 7, 2026 21:51
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jonsurrell, lancewillett.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@lancewillett lancewillett moved this from Backlog to In review in WordPress Project Build Tooling Sep 8, 2026
wporg-sync pushed a commit that referenced this pull request Sep 10, 2026
Save the incoming stylesheet in block and theme test fixtures and switch back during teardown when it changes. Restore the theme before database rollback so theme-related runtime state and caches do not leak into later tests.

Developed in: #13205

Props jonsurrell.
See #65893.


git-svn-id: https://develop.svn.wordpress.org/trunk@63595 602fd350-edb4-49c9-b593-d223f7449a82
wporg-sync pushed a commit to WordPress/WordPress that referenced this pull request Sep 10, 2026
Save the incoming stylesheet in block and theme test fixtures and switch back during teardown when it changes. Restore the theme before database rollback so theme-related runtime state and caches do not leak into later tests.

Developed in: WordPress/wordpress-develop#13205

Props jonsurrell.
See #65893.

Built from https://develop.svn.wordpress.org/trunk@63595


git-svn-id: http://core.svn.wordpress.org/trunk@62771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
@lancewillett

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants