Block Supports: Output flex-direction row when a viewport override switches a vertical flex layout to horizontal. - #13370
Conversation
…itches a vertical flex layout to horizontal.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
talldan
left a comment
There was a problem hiding this comment.
Thanks, fixes the issue for me on the frontend.
…witches a flex layout to horizontal. `row` is the flex default, so the base layout never declares it. When a Tablet or Mobile override switched a vertical (Stack) layout to horizontal, the base `flex-direction: column` kept applying and the block stayed vertical. Backports WordPress/gutenberg#82364. Developed in #13370. Props jorgefilipecosta, talldanwp, firdaus666. Fixes #66096. git-svn-id: https://develop.svn.wordpress.org/trunk@63602 602fd350-edb4-49c9-b593-d223f7449a82
…witches a flex layout to horizontal. `row` is the flex default, so the base layout never declares it. When a Tablet or Mobile override switched a vertical (Stack) layout to horizontal, the base `flex-direction: column` kept applying and the block stayed vertical. Backports WordPress/gutenberg#82364. Developed in WordPress/wordpress-develop#13370. Props jorgefilipecosta, talldanwp, firdaus666. Fixes #66096. Built from https://develop.svn.wordpress.org/trunk@63602 git-svn-id: http://core.svn.wordpress.org/trunk@62778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Backport of WordPress/gutenberg#82364.
Currently, when a vertical (Stack) flex layout is set to horizontal on the tablet or mobile viewports, the block stays vertical. The viewport rule only outputs the justification and the base
flex-direction: columnkeeps applying. This PR fixes the issue by outputtingflex-direction: rowwhen a viewport override switches the orientation to horizontal.Trac ticket: https://core.trac.wordpress.org/ticket/66096
Use of AI Tools
AI assistance: Yes
Used for: fix and tests drafted with AI assistance; reviewed and edited by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.