Check cache return value in WP_Textdomain_Registry::get_language_file… - #13429
Check cache return value in WP_Textdomain_Registry::get_language_file…#13429josephscott wants to merge 4 commits into
Conversation
…s_from_path() https://core.trac.wordpress.org/ticket/66063 I came across this because I ran into a PHP fatal error from the lack of checking the return value from the cache: > Uncaught TypeError: str_starts_with(): Argument WordPress#1 ($haystack) must be of type string, array given Inside of `get_path_from_lang_dir()`.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
sirreal
left a comment
sirreal
left a comment
There was a problem hiding this comment.
This seems good, thank you, I left one suggestion.
sirreal
left a comment
sirreal
left a comment
There was a problem hiding this comment.
@josephscott I pushed a few unit tests for the fatal cases this fixes, please have a look at them.
This seems ready to ship.
``` Deprecation: assertContainsOnly() and assertNotContainsOnly() are deprecated As of PHPUnit 11.5, the assertContainsOnly() and assertNotContainsOnly() methods are hard-deprecated. Using these methods will trigger a deprecation warning. The methods will be removed in PHPUnit 13. ``` From https://docs.phpunit.de/en/12.5/assertions.html
|
Thank you. The tests looked fine, I made one small change, replacing From https://docs.phpunit.de/en/12.5/assertions.html So switching now makes for one less thing to update in the future. If you are good with that, then I agree, this change is ready. |
2 participants
WP_Textdomain_Registry::get_language_files_from_path()https://core.trac.wordpress.org/ticket/66063
I came across this because I ran into a PHP fatal error from the lack of checking the return value from the cache:
Inside of
get_path_from_lang_dir().AI assistance: Yes
Tool(s): Claude
Model(s): Fable 5.1
Used for: Used for discussing the fatal error and narrowing down why it was happening. The code is my own.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.