Formatting: Fix wp_list_pluck() dropping index keys equal to zero - #13452
Formatting: Fix wp_list_pluck() dropping index keys equal to zero#13452haritpanchal wants to merge 2 commits into
Conversation
WP_List_Util::pluck() checked `if ( ! $index_key )` to detect whether an index key was requested, treating 0 the same as null since 0 is falsy in PHP. This silently discarded a valid numeric index key of 0, unlike array_column(), which this method is documented to mirror. Includes regression tests for the array and object cases. Trac ticket: https://core.trac.wordpress.org/ticket/57136
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Summary
WP_List_Util::pluck()usedif ( ! $index_key )to decide whether an index key was provided. Since0is falsy in PHP, passing0as$index_keywas treated identically to not passing one at all, silently dropping the requested keys.array_column()— which this method's docblock says it mirrors — doesn't have this problem.Reproduction (from the ticket)