Skip to content

7.1 branch: Upgrade to Node 24.x - #13454

Draft
desrosj wants to merge 2 commits into
WordPress:7.1from
desrosj:upgrade/7.1-to-node-24
Draft

7.1 branch: Upgrade to Node 24.x#13454
desrosj wants to merge 2 commits into
WordPress:7.1from
desrosj:upgrade/7.1-to-node-24

Conversation

@desrosj

@desrosj desrosj commented Sep 9, 2026

Copy link
Copy Markdown
Member

Trac ticket:

Use of AI Tools


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@desrosj desrosj self-assigned this Sep 9, 2026
@desrosj
desrosj changed the base branch from trunk to 7.1 September 9, 2026 11:09
desrosj and others added 2 commits September 9, 2026 07:09
Today there are 5 default themes that have `package.json` files:
- Twenty Nineteen
- Twenty Twenty
- Twenty Twenty-One
- Twenty Twenty-Two
- Twenty Twenty-Five

The `.nvmrc` file at the root of the repository will be used when modifying these themes in the context of a `wordpress-develop` checkout. But these themes exist outside of `wordpress-develop` more often than not. And there are times where the version of Node.js used by Core is not the same as one or more of the themes (this is currently the case with Twenty Nineteen).

This adds an `.nvmrc` file to each of the 5 themes that rely on Node.js. The theme testing GitHub Actions workflow is also updated to use each theme’s individual `.nvmrc` files to determine which version of Node.js to use instead of always defaulting to the version used for Core itself.

Fixes #66041.

git-svn-id: https://develop.svn.wordpress.org/trunk@63450 602fd350-edb4-49c9-b593-d223f7449a82
This updates the minimum required version of Node.js in Core to `24.18.0`.

Gutenberg has already been bumped, and the `gutenberg.sha` value is being updated to point to the corresponding merge commit.

The Twenty Nineteen and Twenty Twenty themes are remaining on 20.x and 16.x for the time being until a compatibility issue in each dependency tree can be resolved.

Props desrosj, manzoorwanijk, ciampo, SirLouen, jsnajdr, aduth, barry, mukesh27, jonsurrell.

git-svn-id: https://develop.svn.wordpress.org/trunk@63539 602fd350-edb4-49c9-b593-d223f7449a82
@desrosj
desrosj force-pushed the upgrade/7.1-to-node-24 branch from bc00240 to 6556786 Compare September 9, 2026 11:10
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants