Skip to content

Tests: Avoid repeated test invocations in Tests_WpTokenMap #13478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SainathPoojary wants to merge 1 commit into from
+38 −45
Closed

Tests: Avoid repeated test invocations in Tests_WpTokenMap #13478

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 38 additions & 45 deletions tests/phpunit/tests/wp-token-map/wpTokenMap.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,68 +306,63 @@ public static function data_short_substring_matches_of_each_other() {
* Ensures that Token Map searches at appropriate starting offset.
*
* @ticket 60698
*
* @dataProvider data_html5_test_dataset
*
* @param string $token Token to find.
* @param string $replacement Replacement string for token.
*/
public function test_reads_token_at_given_offset( $token, $replacement ) {
$document = "& another {$token} & then some";
$map = self::get_html5_token_map();
public function test_reads_token_at_given_offset() {
$map = self::get_html5_token_map();

$skip_bytes = 0;
$this->assertNull(
$map->read_token( $document, 0, $skip_bytes ),
"Shouldn't have found token at start of document."
);
foreach ( $this->get_html5_test_dataset() as $token => $replacement ) {
$document = "& another {$token} & then some";

$response = $map->read_token( $document, 10, $skip_bytes );
$skip_bytes = 0;
$this->assertNull(
$map->read_token( $document, 0, $skip_bytes ),
"Shouldn't have found token '{$token}' at start of document."
);

$this->assertSame(
strlen( $token ),
$skip_bytes,
"Found the wrong length for token '{$token}'."
);
$response = $map->read_token( $document, 10, $skip_bytes );

$this->assertSame(
$response,
$replacement,
'Found the wrong replacement value for the token.'
);
$this->assertSame(
strlen( $token ),
$skip_bytes,
"Found the wrong length for token '{$token}'."
);

$this->assertSame(
$response,
$replacement,
"Found the wrong replacement value for token '{$token}'."
);
}
}

/**
* Ensures that all given tokens exist inside a constructed Token Map.
*
* @ticket 60698
*
* @dataProvider data_html5_test_dataset
*
* @param string $token Token to find.
* @param string $replacement Not used in this test.
*/
public function test_detects_all_tokens( $token, $replacement ) {
public function test_detects_all_tokens() {
$map = self::get_html5_token_map();

$this->assertTrue(
$map->contains( $token ),
"Should have found '{$token}' inside the Token Map, but didn't."
);
foreach ( $this->get_html5_test_dataset() as $token => $replacement ) {
$this->assertTrue(
$map->contains( $token ),
"Should have found '{$token}' inside the Token Map, but didn't."
);

$double_escaped_token = str_replace( '&', '&', $token );
$this->assertFalse(
$map->contains( $double_escaped_token ),
"Should not have found '{$double_escaped_token}' in Token Map, but did."
);
$double_escaped_token = str_replace( '&', '&', $token );
$this->assertFalse(
$map->contains( $double_escaped_token ),
"Should not have found '{$double_escaped_token}' in Token Map, but did."
);
}
}

/**
* Data provider.
* Gets all HTML5 named character references to check within each test.
*
* @return array[].
* @return string[] Replacement strings keyed by token.
*/
public function data_html5_test_dataset() {
private function get_html5_test_dataset() {
$html5 = self::get_test_input_array( 'HTML5' );

$this->assertSame(
Expand All @@ -376,9 +371,7 @@ public function data_html5_test_dataset() {
'Found the wrong number of HTML5 named character references: confirm the entities.json file."'
);

foreach ( $html5 as $token => $replacement ) {
yield $token => array( $token, $replacement );
}
return $html5;
}

/**
Expand Down
Loading