Tests: Use assertWPError() for WP_Error assertions in classic-to-block menu converter tests - #13501
Open
noruzzamans wants to merge 1 commit into
Open
Conversation
…k menu converter tests. Replaces a generic assertTrue( is_wp_error() ) assertion with the dedicated assertWPError() assertion in WP_Classic_To_Block_Menu_Converter_Test. Follow-up to r56052, r58183. See #65819.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces a generic
assertTrue( is_wp_error() )assertion intests/phpunit/tests/editor/classic-to-block-menu-converter.phpwith WordPress's dedicatedassertWPError()assertion.Using dedicated assertion methods improves failure reporting by automatically including the
WP_Errorcode and message in assertion failure outputs.This was the only remaining occurrence of
assertTrue( is_wp_error() )in the test suite.This is a test-only change and does not affect runtime behavior.
Background
WP_Classic_To_Block_Menu_Converter_Testwas introduced in [56052] (Trac #58557). In [58183] (Trac #60705), assertions in this file were tightened toassertSame(). This update completes modernizing the error assertion to useassertWPError().Follow-up to r56052, r58183.
Trac ticket: https://core.trac.wordpress.org/ticket/65819
Use of AI Tools
AI assistance: Yes
Model(s): Gemini 3.8 Flash High
Used for: Scanning the test suite for legacy generic boolean assertions,
git log -Larchaeology identifying [56052] and [58183], and drafting this description. The code change, verification, and coding standards compliance were reviewed and confirmed by me in a local development environment.This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.