Build/Test Tools: Update PHPStan baseline for WP_Query::$posts assignment - #13504
Open
wppoland wants to merge 1 commit into
Open
Build/Test Tools: Update PHPStan baseline for WP_Query::$posts assignment#13504wppoland wants to merge 1 commit into
wppoland wants to merge 1 commit into
Conversation
…ment. In r63607, query variable defaults and post properties were updated to use the null coalescing assignment operator (`??=`) in `WP_Query`. This reduced the occurrences of `assign.propertyType` for `WP_Query::$posts` from 2 to 1 in `src/wp-includes/class-wp-query.php`. This commit updates `tests/phpstan/baselines/assign.propertyType.neon` accordingly so PHPStan CI checks pass on trunk and PRs. Follow-up to [63607]. Props wppoland. See #65823.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In [63607] (ticket #65823), query variable defaults and post properties were updated to use the null coalescing assignment operator (
??=) inWP_Query.This change reduced the occurrence count of
assign.propertyTypeforWP_Query::$postsinsrc/wp-includes/class-wp-query.phpfrom 2 to 1. As a result, PHPStan CI workflows on trunk and open PRs fail at theCheck whether the baselines need regeneratingstep.This PR updates
tests/phpstan/baselines/assign.propertyType.neonso PHPStan static analysis passes cleanly again.Follow-up to [63607].
Trac ticket: https://core.trac.wordpress.org/ticket/65823