#52217 - PHPStan config and fixes - #853

Closed

johnbillion wants to merge 67 commits into

WordPress:masterfrom

johnbillion:feature/phpstan

Commits on Jan 3, 2021

Basic PHPStan configuration.
johnbillion
committed
f117536
Start reducing the noise.
johnbillion
committed
602cf9a

Commits on Jan 4, 2021

More noise reduction.
johnbillion
committed
8754812
More enquietening.
johnbillion
committed
9c6c482
Avoid some Multisite errors.
johnbillion
committed
8dcb1aa
Formatting.
johnbillion
committed
3b9cc08
Move onto level 1 analysis, ignore more files.
johnbillion
committed
83db700
Docs.
johnbillion
committed
6444bd7
Ignore WP_List_Table protected property access.
johnbillion
committed
038a83c
More ignorance.
johnbillion
committed
0f2d8d0
Formatting.
johnbillion
committed
6b40bb1

Commits on Jan 5, 2021

Move the bootstrap file.
johnbillion
committed
a9fec7d
Add a Composer script.
johnbillion
committed
3f02f83

Commits on Jun 19, 2021

Correct the indentation rule for Neon files.
johnbillion
committed
65416fc
Correct some calls to `remove_filter()`.
johnbillion
committed
f2efb03
Correct some class names.
johnbillion
committed
75346da
These are too noisy at the moment.
johnbillion
committed
dd878f9
Properly initialise some variables.
johnbillion
committed
e0cb482
Unset the correct variable.
johnbillion
committed
a763bb9
Merge branch 'master' into feature/phpstan
johnbillion
committed
00c8bcc
This is no longer needed.
johnbillion
committed
9c63eb8

Commits on Jul 10, 2021

Merge branch 'master' into feature/phpstan
johnbillion
committed
d6f1ba5
Update PHPStan.
johnbillion
committed
8a4484c
This is too noisy at the moment.
johnbillion
committed
34f2c7d
These aren't needed.
johnbillion
committed
1d16f0f
Make this less specific so it catches uses in isset too.
johnbillion
committed
1f089ab
Not worried about unused parameters for now.
johnbillion
committed
226fffa
Reduce noise again.
johnbillion
committed
c8f7eea
This `$s` is extracted in `load_template()`.
johnbillion
committed
0654bdd
Ignore Gutenberg compat functions.
johnbillion
committed
dc61845
Add and document missing properties.
johnbillion
committed
3366d52
Fix an undefined variable.
johnbillion
committed
0f607bc
Fix a property name.
johnbillion
committed
5602b43
Add some PHPStan-specific docs tags to help with return types.
johnbillion
committed
f702b6c
Allow and ignore a local PHPStan config file.
johnbillion
committed
ba1677d
Correct a return type. Child classes don't need to (and often don't) return anything from this method.
johnbillion
committed
d9e2808
Inline docs.
johnbillion
committed
b74302e
Correct some return types.
johnbillion
committed
aeb3dd7
More ignorance.
johnbillion
committed
959abcc
Different approach to GdImage so parameter types work too.
johnbillion
committed
9bce724
More inline docs.
johnbillion
committed
6798925
Generics fixes.
johnbillion
committed
d762914
Dunno what's up with this.
johnbillion
committed
da96222
What on earth.
johnbillion
committed
bf069f9
Document some private and protected properties that are publicly accessible.
johnbillion
committed
c42e821
We know what these are.
johnbillion
committed
d21c668
These functions always terminate.
johnbillion
committed
3689ca8
Don't need to sniff this.
johnbillion
committed
786d69b
Cast some types that are used in calculations.
johnbillion
committed
0a84206

Commits on Jul 11, 2021

Not much we can do about undocumented objects.
johnbillion
committed
1f0a819
Fix the never returns.
johnbillion
committed
608483d
Fix some default parameters.
johnbillion
committed
7a4efb4
Fix some default parameter values.
johnbillion
committed
b51bf00
Fix an inline type.
johnbillion
committed
7cfde63
Document protected properties that are publicly exposed via `__get()`.
johnbillion
committed
7e15940
Fix some default parameter values.
johnbillion
committed
f9b672d
Fix some return values.
johnbillion
committed
e485b62
This should return, not echo.
johnbillion
committed
ae4a869
Document protected properties that are publicly exposed via `__get()`.
johnbillion
committed
fc2d91d
Be more specific about which files are scanned and which are just analysed.
johnbillion
committed
e0985a9
Fix another default value.
johnbillion
committed
0ce4e66

Commits on Jul 19, 2021

Replace this inline comment with proper PHPCS configuration.
johnbillion
committed
27bbc1d

Commits on Jul 20, 2021

Commits on Sep 22, 2021

Merge branch 'master' into feature/phpstan
johnbillion
committed
231430c
Merge branch 'master' into feature/phpstan
johnbillion
committed
1ba90e4