Skip to content

test(ripgrep): add coverage for legacy probe paths and priority ordering in getBinPath #296

Description

@edelauna

Currently getBinPath has 6 probe paths but tests only cover 3 of them (classic @vscode/ripgrep, universal, unpacked-universal). The legacy layouts have no test coverage:

  • node_modules/vscode-ripgrep/bin
  • node_modules.asar.unpacked/vscode-ripgrep/bin/
  • node_modules.asar.unpacked/@vscode/ripgrep/bin/

Additionally, there is no test asserting probe priority — i.e. that the classic layout wins when more than one path exists simultaneously. The waterfall ordering in getBinPath is load-bearing and a silent reordering would pass the current suite.

Surfaced during review of #248.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions