Skip to content

Create push notification config returns no id on database-backed stores #1237

Description

@ConnorMoss02

What happens

Creating a push notification config against a database-backed server returns a config with no id. Reading it back with that id raises InvalidParamsError.

create returned id = ''
get FAILED -> InvalidParamsError: Validation failed

The same calls against the in-memory store return id='task-123' and the get succeeds.

Why

on_create_task_push_notification_config returns the caller's request object rather than what the store persisted (default_request_handler.py:556, default_request_handler_v2.py:394).

Both stores default an empty id to the task id, on different objects:

  • inmemory_push_notification_config_store.py:51 sets it on the caller's object, so return params carries it.
  • database_push_notification_config_store.py:292 copies first and sets it on the copy, so params never gets it.

The store holds the right id either way; only the response differs.

Version

main @ d55a3d3

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

component: serverIssues related to frameworks for agent execution, HTTP/event handling, database persistence logic.status:awaiting response

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions