Bump version to 1.0.0#1
Merged
Merged
Conversation
- Bump version from 0.1.0 to 1.0.0 - Update homepage to activeadmin-plugins org
4 tasks
Fivell
added a commit
that referenced
this pull request
Jun 2, 2026
HIGH #1 — concurrent JIT provisioning re-runs on_login. On the RecordNotUnique retry path, @Retried is already set in save!'s rescue. Use it in #call to short-circuit on the retry: return the winner's row verbatim instead of re-running invoke_on_login (which would double-fire host-side side effects like audit log rows, webhooks, emails). HIGH #2 — disabled user persisted before active_for_authentication? check. Add the Devise inactivity guard inside #call, BETWEEN on_login and save!. A hostile attempt where on_login flips an inactivity flag (e.g. enabled=false) and returns truthy used to leave a provisional row in the DB on every try; now it raises ProvisioningError with the model's inactive_message and no row is written. HIGH #3 — identity-claim adoption ignored email_verified. find_or_adopt_or_build now refuses to link a pre-existing (provider/uid-nil) row when the claim explicitly carries email_verified: false. IdPs that don't ship the claim at all keep the old behaviour, preserving compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After merge, release with: rake release