Add support for custom HTTP headers when talking to the unleash server#3
Open
rarruda wants to merge 1 commit into
Open
Add support for custom HTTP headers when talking to the unleash server#3rarruda wants to merge 1 commit into
rarruda wants to merge 1 commit into
Conversation
This is essential if you have your unleash server protected by an API key
|
Any chances to get this one merged @aes ? |
Owner
|
Hi
Sorry for the slow response. I really have no idea what happened to this.
We were /are happy users of unleash, but it's being discontinued in favour
of an in-house tool that is (to my mind) massively over engineered.
In any case, I think I would handle the context differently if I did it all
over again, (it turns out to be useful in more places, e.g. logging) but
what's there is still sound, iirc, so you should think for yourself and
decide what works for you.
If you're wondering about any particular feature, version control is
correct, everything else is just random opinions.
As always,
Good luck, have fun!
Cheers
Anders
…On Fri, 25 Jan 2019, 15:17 Pierre Houssin ***@***.*** wrote:
Any chances to get this one merged @aes <https://github.com/aes> ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AASLb4SkSaqeQROL2fBCGz0mAO0rZ33Zks5vGyAjgaJpZM4WyM7l>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is essential if you have your unleash server protected by an API key.