Conversation
Revision on Assignment Week 02
helenhash
requested changes
Jul 20, 2024
Collaborator
There was a problem hiding this comment.
I do not see any entity relation between entites (ex: employee - dept, ...)
For APIs, we need to show more information, for example, employee info need including his/her departments, his/her current salary, tittle (if he/she has)
Similarly, when we create/update an employee, how to specific his/her departments...
AliRamdhan
reviewed
Jul 22, 2024
Collaborator
There was a problem hiding this comment.
Overall this is good for documention to use composite key with JPA and make CRUD with relational database
Collaborator
There was a problem hiding this comment.
This is great implementation to search employee by dynamic criteria with DTOCriteria
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My assignment submission during Lecture 11 and 12