fix: make E2E test timeouts configurable and add sensitive directory test#206
Merged
Conversation
Add max_retries parameter to prevent infinite retry loops when API rate limits are hit. Changes: - Add max_retries parameter (default: 3) to LLMEnricher.enrich_skill() - Add retry counter tracking with _retry_count internal parameter - Implement jitter to prevent thundering herd problem - Add graceful fallback to heuristic skill on max retries exceeded - Add --llm-max-retries CLI option (range: 0-10, default: 3) - Thread parameter through learning_service.py workflow Security improvements: - Bounded retries prevent runaway API costs - Helpful error messages with API quota link - Graceful degradation when retries exhausted Fixes #104 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…test Improve test reliability and security coverage. Changes: - Add DEFAULT_TIMEOUT environment variable (default: 90s) - Replace all hardcoded timeout=60 with DEFAULT_TIMEOUT - Add new E2E test for sensitive directory blocking Benefits: - Prevents flaky test failures on slower CI runners - Allows developers to adjust timeout based on environment - Adds end-to-end test coverage for critical security feature - Validates sensitive directory prompts work correctly Configuration: - Set AGENTREADY_TEST_TIMEOUT environment variable to override default - Example: export AGENTREADY_TEST_TIMEOUT=120 (for slower systems) Fixes #192 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 2.19.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
DEFAULT_TIMEOUTenvironment variable (default: 90s)timeout=60withDEFAULT_TIMEOUTTestCriticalSecurityFeaturesclasstest_assess_blocks_sensitive_directories()E2E testBenefits
Configuration
Set
AGENTREADY_TEST_TIMEOUTenvironment variable to override default:Test Plan
Fixes #192
🤖 Generated with Claude Code
Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com