Skip to content

gulp-filter@4.0.0 will miss file when building, while gulp-filter@3.0.1 OK #2146

@jacinchan

Description

@jacinchan
Item Version
generator-angular-fullstack 3.7.6
Node 5.10.1
npm x.x.x
Operating System OS X 10 / Windows 10 / Ubuntu 15.10 / etc
etc etc
Item Answer
Transpiler Babel
Markup HTML
CSS SCSS
Router ui-router
Client Tests Mocha
DB MongoDB
Auth N
etc etc

when I use gulp build, i found app.js did not uglity or rev
problem is
gulp-filter@4.0.0 will miss some files.
if i reset to gulp-filter@3.0.1, it's OK
see the gulp file here

in gulp.task('build:client')

return gulp.src(paths.client.mainView)
.pipe(plugins.useref())
.pipe(appFilter)
.pipe(plugins.addSrc.append('.tmp/templates.js'))
.pipe(plugins.concat('app/app.js'))
.pipe(appFilter.restore) ------------- // app/app.js is included
.pipe(jsFilter) ------------- // app/app.js is excluded!
.pipe(plugins.ngAnnotate())
.pipe(plugins.uglify())
.pipe(jsFilter.restore)
.pipe(cssFilter)
.pipe(plugins.cleanCss({
processImportFrom: ['!fonts.googleapis.com']
}))
.pipe(cssFilter.restore)
.pipe(htmlBlock) //the same problem here
.pipe(plugins.rev())
.pipe(htmlBlock.restore)
.pipe(plugins.revReplace({manifest}))
.pipe(gulp.dest(${paths.dist}/${clientPath}));

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions