Generator tests pass erroneously?

[kingcody]

I was looking at the test for the generator, in particular the should pass jshint. All of the test pass when I run grunt test in the generator folder (generator-angular-fullstack). However when i cd test/temp && grunt jshint the task jshint:all actually fails. I'm kind of confussed being that it looks like test/test-file-creation.js checks to make sure the jshint:all task passes.

Anyone have any ideas on this one?

[kingcody]

I see, when testing with defaultOptions there is no assertion for should pass jshint

[kingcody]

Adding:

it('should pass jshint', function(done) {
  this.timeout(60000);
  gen.run({}, function () {
    exec('grunt jshint', function (error, stdout, stderr) {
      expect(stdout).to.contain('Running "jshint:server" (jshint) task\u001b[24m\n\n✔ No problems');
      expect(stdout).to.contain('Running "jshint:all" (jshint) task\u001b[24m\n\n✔ No problems');
      done();
    });
  });
});

to line ~80 in test/test-file-creation.js resolves this issue and exposes the jshint:all fail that should be expected currently with defaultOptions selected.

[kingcody]

I can include this fix, along with the lint errors in #482 if others are in agreement that linting with defaultOptions should be tested.

[DaftMonk]

Good catch!

[kingcody]

Closed by #482