Web Worker support by filipesilva · Pull Request #13700 · angular/angular-cli

filipesilva · 2019-02-18T17:11:06Z

Followup to #12575

Todo:

Serginho · 2019-02-19T10:18:10Z

@filipesilva I'm following this feature closely and I can see worker plugin won't support lazy loading. it's only a suggestion.

Why don't you bundle the workers using webpack multiple targets?
export.module = [{target: 'web', ....}, {target: 'webworker' ...}]

Or maybe you are not doing this thinking in platform-webworker?

filipesilva · 2019-02-19T10:30:41Z

@Serginho at the moment I'm just following the base functionality of https://github.com/googlechromelabs/worker-plugin. It only supports { type:'module' }. The functionality as is right now isn't meant to support @angular/platform-webworker, but rather just to bundle web workers.

filipesilva · 2019-03-06T17:43:09Z

+    // Add project tsconfig.json and tsconfig.worker.json.
+    // The project level tsconfig.json with webworker lib is for editor support since
+    // the dom and webworker libs are mutually exclusive.
+    // Note: this schematic does not change other tsconfigs to use the project-level tsconfig.


This schematic makes a two new tsconfig files:

path/to/project/tsconfig.worker.json for the worker TS compilation itself

path/to/project/tsconfig.json for the editor to support both DOM and WebWorker typings inside the project

As is I did not make the remaining tsconfigs in path/to/project/ extend path/to/project/tsconfig.json because it's hard to ensure they are the default tsconfigs we generate on a new project.

But I believe we should eventually transition into having a path/to/project/tsconfig.json anyway in all projects because of other editor support issues like #8138 (comment).

filipesilva · 2019-03-07T14:20:36Z

+      // 'src/worker/dep.ts'.
+      // But increasing this delay to 5s lead to no failed test in over 40 runs locally.
+      // In CI I still saw a rebuild fail with 5s, so I increased it to 10s.
+      // I think there might be a race condition related to child compilers somewhere in webpack.


Still saw a failure with the 10s debounce time in https://circleci.com/gh/angular/angular-cli/43023#tests/containers/1. Need to debug further.

@filipesilva Is it possible the child compiler needs additional plugins? If it does and their configuration is the same, adding a string match pattern to the plugins[] option in worker-plugin would copy them over.

I'm not sure where to look in this repo to peek at how file watching is being done, any tips appreciated!

I'm looking at this currently. I'm not 100% sure of what the problem is but I've managed to reproduce it locally. I think it's related to the shared bits of our TS compilation pipeline.

I think I figured it out, let's continue the conversation in the other comment (#13700 (comment)).

owenhaynes · 2019-03-18T11:44:12Z

Will this also enable shared workers as well?

filipesilva · 2019-03-18T17:58:36Z

@owenhaynes I'm not sure what you mean, can you give an example please?

alan-agius4

This is really good!

Couple of small things above.

alan-agius4

LGTM

Supports new Worker(...,{type:module}) using github.com/googlechromelabs/worker-plugin

…ions

…chitect

Followup to angular/angular-cli#13700 PR Close #29633

…lder Followup to angular#13700, the karma builder did not get the same support but it should.

…lder Followup to #13700, the karma builder did not get the same support but it should.

Followup to angular/angular-cli#13700 PR Close angular#29633

angular-automatic-lock-bot · 2019-09-13T01:41:04Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Feb 18, 2019

alan-agius4 reviewed Feb 18, 2019

View reviewed changes

Comment thread packages/angular/cli/lib/config/schema.json Outdated

filipesilva force-pushed the pr12575-followup branch from 9f269a9 to 0b19406 Compare February 18, 2019 20:19

filipesilva force-pushed the pr12575-followup branch from 0b19406 to c203f94 Compare February 19, 2019 11:31

developit reviewed Feb 19, 2019

View reviewed changes

Comment thread packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/common.ts Outdated

filipesilva commented Feb 19, 2019

View reviewed changes

Comment thread packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/worker.ts

filipesilva force-pushed the pr12575-followup branch 2 times, most recently from 651a873 to c4d7750 Compare February 21, 2019 14:52

filipesilva added the needs: discussion On the agenda for team meeting to determine next steps label Feb 21, 2019

filipesilva force-pushed the pr12575-followup branch 2 times, most recently from 0717c0a to 7471ca1 Compare February 25, 2019 19:22

filipesilva force-pushed the pr12575-followup branch 2 times, most recently from 7bcfd12 to b35f1ad Compare February 28, 2019 17:43

mgechev removed the needs: discussion On the agenda for team meeting to determine next steps label Feb 28, 2019

hansl reviewed Feb 28, 2019

View reviewed changes

Comment thread packages/angular/cli/lib/config/schema.json Outdated

filipesilva force-pushed the pr12575-followup branch 2 times, most recently from c7041a1 to d361f51 Compare February 28, 2019 18:31

filipesilva added the state: WIP label Feb 28, 2019

filipesilva force-pushed the pr12575-followup branch from d361f51 to f9def41 Compare February 28, 2019 18:32

filipesilva commented Feb 28, 2019

View reviewed changes

Comment thread packages/schematics/angular/web-worker/index.ts Outdated

filipesilva commented Feb 28, 2019

View reviewed changes

Comment thread packages/schematics/angular/web-worker/index.ts Outdated

filipesilva force-pushed the pr12575-followup branch 2 times, most recently from 638fc11 to 8c14243 Compare March 6, 2019 17:37

filipesilva commented Mar 6, 2019

View reviewed changes

filipesilva commented Mar 7, 2019

View reviewed changes

alexzuza mentioned this pull request Mar 11, 2019

feat(@ngtools/webpack): Automatically bundle module workers #12575

Closed

alan-agius4 requested changes Mar 29, 2019

View reviewed changes

filipesilva force-pushed the pr12575-followup branch 4 times, most recently from 1e3e52e to 44dbe6e Compare April 1, 2019 09:29

filipesilva changed the title ~~bundle module workers followup~~ Web Worker support Apr 1, 2019

alan-agius4 approved these changes Apr 1, 2019

View reviewed changes

filipesilva force-pushed the pr12575-followup branch from 44dbe6e to e44e508 Compare April 1, 2019 10:06

alan-agius4 mentioned this pull request Apr 1, 2019

updating webpack config for differential loading #14015

Closed

filipesilva mentioned this pull request Apr 1, 2019

docs: add Web Worker guide angular/angular#29633

Closed

14 tasks

clydin reviewed Apr 1, 2019

View reviewed changes

Comment thread packages/angular_devkit/build_angular/package.json Outdated

developit and others added 6 commits April 1, 2019 17:42

feat(@angular-devkit/build-angular): support module web workers.

d9249c9

Supports new Worker(...,{type:module}) using github.com/googlechromelabs/worker-plugin

test(@angular-devkit/build-angular): test worker bundling

cf3171f

feat(@ngtools/webpack): reuse compiler host in webpack child compilat…

224cbe1

…ions

feat(@angular-devkit/build-angular): support TS web workers

ced9890

feat(@schematics/angular): add web worker schematics

f294851

refactor(@angular-devkit/build-angular): support web worker in new ar…

4c92bad

…chitect

filipesilva force-pushed the pr12575-followup branch from e44e508 to 4c92bad Compare April 1, 2019 16:42

clydin approved these changes Apr 1, 2019

View reviewed changes

jasonaden pushed a commit to angular/angular that referenced this pull request Apr 1, 2019

docs: add Web Worker guide (#29633)

8bfaaf1

Followup to angular/angular-cli#13700 PR Close #29633

mgechev merged commit 6e0a040 into angular:master Apr 2, 2019

filipesilva mentioned this pull request Apr 8, 2019

build(docs-infra): update to latest CLI beta angular/angular#29764

Closed

14 tasks

filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Apr 10, 2019

feat(@angular-devkit/build-angular): support web workers in karma bui…

2842674

…lder Followup to angular#13700, the karma builder did not get the same support but it should.

filipesilva mentioned this pull request Apr 10, 2019

feat(@angular-devkit/build-angular): support web workers in karma bui… #14122

Merged

alexeagle pushed a commit that referenced this pull request Apr 10, 2019

feat(@angular-devkit/build-angular): support web workers in karma bui…

323c883

…lder Followup to #13700, the karma builder did not get the same support but it should.

filipesilva deleted the pr12575-followup branch April 15, 2019 15:03

filipesilva mentioned this pull request Apr 15, 2019

Feature request: support fixed filename GoogleChromeLabs/worker-plugin#19

Closed

wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019

docs: add Web Worker guide (angular#29633)

b9b37e0

Followup to angular/angular-cli#13700 PR Close angular#29633

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019

Conversation

filipesilva commented Feb 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Serginho commented Feb 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

filipesilva commented Feb 19, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

filipesilva Mar 6, 2019

Choose a reason for hiding this comment

Uh oh!

filipesilva Mar 7, 2019

Choose a reason for hiding this comment

Uh oh!

developit Mar 21, 2019

Choose a reason for hiding this comment

Uh oh!

filipesilva Mar 22, 2019

Choose a reason for hiding this comment

Uh oh!

filipesilva Mar 22, 2019

Choose a reason for hiding this comment

Uh oh!

owenhaynes commented Mar 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

filipesilva commented Mar 18, 2019

Uh oh!

alan-agius4 left a comment

Choose a reason for hiding this comment

Uh oh!

alan-agius4 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

angular-automatic-lock-bot Bot commented Sep 13, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

filipesilva commented Feb 18, 2019 •

edited

Loading

Serginho commented Feb 19, 2019 •

edited

Loading

owenhaynes commented Mar 18, 2019 •

edited

Loading