fix(@schematics/angular): move and update existing src/browserslist#14241
Merged
Conversation
Older projects have their `browserslist` file under the `src` folder. Fixes #14232
alan-agius4
added
the
target: patch
filipesilva
approved these changes
Apr 23, 2019
alexeagle
reviewed
Apr 23, 2019
| it('should move browserslist file if it exists in the sourceRoot', () => { | ||
| tree.create('/src/browserslist', 'last 2 Chrome versions'); | ||
| tree.delete('/browserslist'); | ||
| const tree2 = schematicRunner.runSchematic('migration-07', {}, tree.branch()); |
Contributor
There was a problem hiding this comment.
I am confused why these all say migration-07
Collaborator
Author
There was a problem hiding this comment.
It's the migration name. For example for Angular CLI version 8, we have multiple migrations.
Collaborator
Author
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Older projects have their
browserslistfile under thesrcfolder.Fixes #14232