fix(@schematics/angular): remove tsquery peer dependency warning#14271
Merged
Conversation
Replaces the usage of the tsquery package with a conditional based on TypeScript helper functions. Since a TypeScript-subset is vendored within the package, a TypeScript peer dependency cannot be met even though the functionality is present. Fixes angular#14270
Contributor
|
another option would be to vendor tsquery into the package as well. If we thought the library will be useful for writing future migrations or checks, we might want to have it around? also relates to Igor's suggestion that we have a package used by migrations so they only ever need that one dep. He worries that with things like |
alexeagle
approved these changes
Apr 25, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the usage of the tsquery package with a conditional based on TypeScript helper functions. Since a TypeScript-subset is vendored within the package, a TypeScript peer dependency cannot be met even though the functionality is present.
Fixes #14270