Skip to content

fix(@schematics/angular): remove tsquery peer dependency warning#14271

Merged
alexeagle merged 1 commit into
angular:masterfrom
clydin:remove-tsquery
Apr 25, 2019
Merged

fix(@schematics/angular): remove tsquery peer dependency warning#14271
alexeagle merged 1 commit into
angular:masterfrom
clydin:remove-tsquery

Conversation

@clydin
Copy link
Copy Markdown
Member

@clydin clydin commented Apr 25, 2019

Replaces the usage of the tsquery package with a conditional based on TypeScript helper functions. Since a TypeScript-subset is vendored within the package, a TypeScript peer dependency cannot be met even though the functionality is present.

Fixes #14270

Replaces the usage of the tsquery package with a conditional based on TypeScript helper functions.  Since a TypeScript-subset is vendored within the package, a TypeScript peer dependency cannot be met even though the functionality is present.

Fixes angular#14270
@alexeagle
Copy link
Copy Markdown
Contributor

another option would be to vendor tsquery into the package as well. If we thought the library will be useful for writing future migrations or checks, we might want to have it around?

also relates to Igor's suggestion that we have a package used by migrations so they only ever need that one dep. He worries that with things like @angular/core adding migrations, we end up with tooling deps in a lot of third-party libraries

@phenomnomnominal FYI

@alexeagle alexeagle merged commit 5765777 into angular:master Apr 25, 2019
@clydin clydin deleted the remove-tsquery branch April 25, 2019 16:30
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

npm WARN @phenomnomnominal/tsquery@3.0.0 requires a peer of typescript@^3 but none is installed

3 participants