perf(@angular/build): enable fast-path AST printing with sourcemaps in AotCompilation#33526
Open
clydin wants to merge 1 commit into
Open
perf(@angular/build): enable fast-path AST printing with sourcemaps in AotCompilation#33526clydin wants to merge 1 commit into
clydin wants to merge 1 commit into
Conversation
angular-robot
Bot
added
area: performance
clydin
force-pushed
the
perf/fast-path-sourcemaps
branch
4 times, most recently
from
8e4d95f to
480d884
Compare
…n AotCompilation Previously, when sourcemaps were enabled, AotCompilation was forced to run the full, slow TypeScript compilation/emit path (`useTypeScriptTranspilation = true`) because the standard `ts.createPrinter().printFile` method does not support generating sourcemaps. This commit leverages TypeScript's internal `createTextWriter`, `createSourceMapGenerator`, and `printer.writeFile` APIs to generate sourcemaps directly during AST printing. This allows AotCompilation to use the fast AST transformation and printing path even when sourcemaps are enabled (as long as `isolatedModules` is true), drastically improving rebuild performance for dev server builds.
clydin
force-pushed
the
perf/fast-path-sourcemaps
branch
from
585f0c5 to
fe96bc9
Compare
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
clydin
added
the
action: review
Member
Author
|
/gemini review |
This comment was marked as duplicate.
This comment was marked as duplicate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when sourcemaps were enabled, AotCompilation was forced to run the full, slow TypeScript compilation/emit path (
useTypeScriptTranspilation = true) because the standardts.createPrinter().printFilemethod does not support generating sourcemaps.This commit leverages TypeScript's internal
createTextWriter,createSourceMapGenerator, andprinter.writeFileAPIs to generate sourcemaps directly during AST printing.This allows AotCompilation to use the fast AST transformation and printing path even when sourcemaps are enabled (as long as
isolatedModulesis true), drastically improving rebuild performance for dev server builds.