fix(cdk/a11y): focus trap not finding tabbable elements in shadow DOM#33506
Open
arturovt wants to merge 1 commit into
Open
fix(cdk/a11y): focus trap not finding tabbable elements in shadow DOM#33506arturovt wants to merge 1 commit into
arturovt wants to merge 1 commit into
Conversation
FocusTrap walked the DOM tree using `Element.children`, which only returns light DOM children and never crosses into a nested element's shadow root. Custom elements (e.g. Lit-based components) that place their tabbable content in shadow DOM were invisible to `_getFirstTabbableElement`/`_getLastTabbableElement`, so the trap would skip over an entire region and its anchors would hand off focus to unrelated content instead of wrapping. Walk into `shadowRoot.children` before `children` when a root has a shadow root, approximating shadow-including tree order. Fixes angular#32265
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FocusTrap walked the DOM tree using
Element.children, which only returns light DOM children and never crosses into a nested element's shadow root. Custom elements (e.g. Lit-based components) that place their tabbable content in shadow DOM were invisible to_getFirstTabbableElement/_getLastTabbableElement, so the trap would skip over an entire region and its anchors would hand off focus to unrelated content instead of wrapping.Walk into
shadowRoot.childrenbeforechildrenwhen a root has a shadow root, approximating shadow-including tree order.Fixes #32265