build: update dependency @web/test-runner-core to v1#3838
Conversation
See associated pull request for more information.
There was a problem hiding this comment.
Code Review
This pull request upgrades the @web/test-runner-core dependency to version ^1.0.0 and updates the lockfile. However, this introduces a critical version mismatch because @web/test-runner and its associated plugins (like @web/test-runner-puppeteer) still resolve to and depend on @web/test-runner-core version 0.13.4. This mismatch can lead to runtime errors and unexpected behavior, so it is highly recommended to upgrade @web/test-runner and its plugins to versions compatible with the new core runner version.
| "@web/test-runner": "^0.20.2", | ||
| "@web/test-runner-core": "^0.13.4", | ||
| "@web/test-runner-core": "^1.0.0", |
There was a problem hiding this comment.
Upgrading @web/test-runner-core to ^1.0.0 while keeping @web/test-runner at ^0.20.2 introduces a version mismatch.
In pnpm-lock.yaml, @web/test-runner@0.20.2 and @web/test-runner-puppeteer@0.18.0 still resolve to and depend on @web/test-runner-core@0.13.4. However, the direct dependency on @web/test-runner-core is now resolved to 1.0.0.
This is highly problematic because wtr.config.mjs reads session.js directly from node_modules/@web/test-runner-core/browser/session.js (which will resolve to version 1.0.0), whereas the test runner itself will execute using version 0.13.4. This mismatch can lead to runtime errors or unexpected behavior.
Please upgrade @web/test-runner and its associated plugins (like @web/test-runner-puppeteer) to versions that are compatible with @web/test-runner-core ^1.0.0 to ensure a single, unified version of the core runner is used.
This PR contains the following updates:
^0.13.4→^1.0.0Release Notes
modernweb-dev/web (@web/test-runner-core)
v1.0.0Compare Source
Major Changes
5260164: Drop support for Node.js 18 and 20, which have reached end-of-life. The minimum supported Node.js version is now 22.0.0.The Node code is compiled to ES2024 which is aligned with the Node 22.
Patch Changes
1a058e6]5260164]8fe1b90]