Skip to content

build: update dependency @web/test-runner-core to v1#3838

Open
angular-robot wants to merge 1 commit into
angular:mainfrom
angular-robot:ng-renovate/web-test-runner-core-1-x
Open

build: update dependency @web/test-runner-core to v1#3838
angular-robot wants to merge 1 commit into
angular:mainfrom
angular-robot:ng-renovate/web-test-runner-core-1-x

Conversation

@angular-robot

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@web/test-runner-core (source) ^0.13.4^1.0.0 age adoption passing confidence

  • If you want to rebase/retry this PR, check this box

Release Notes

modernweb-dev/web (@​web/test-runner-core)

v1.0.0

Compare Source

Major Changes
  • 5260164: Drop support for Node.js 18 and 20, which have reached end-of-life. The minimum supported Node.js version is now 22.0.0.
    The Node code is compiled to ES2024 which is aligned with the Node 22.
Patch Changes

See associated pull request for more information.
@angular-robot angular-robot added action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: automation This PR is targeted to only merge into the branch defined in Github [bot use only] labels Jul 10, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the @web/test-runner-core dependency to version ^1.0.0 and updates the lockfile. However, this introduces a critical version mismatch because @web/test-runner and its associated plugins (like @web/test-runner-puppeteer) still resolve to and depend on @web/test-runner-core version 0.13.4. This mismatch can lead to runtime errors and unexpected behavior, so it is highly recommended to upgrade @web/test-runner and its plugins to versions compatible with the new core runner version.

Comment on lines 24 to +25
"@web/test-runner": "^0.20.2",
"@web/test-runner-core": "^0.13.4",
"@web/test-runner-core": "^1.0.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Upgrading @web/test-runner-core to ^1.0.0 while keeping @web/test-runner at ^0.20.2 introduces a version mismatch.

In pnpm-lock.yaml, @web/test-runner@0.20.2 and @web/test-runner-puppeteer@0.18.0 still resolve to and depend on @web/test-runner-core@0.13.4. However, the direct dependency on @web/test-runner-core is now resolved to 1.0.0.

This is highly problematic because wtr.config.mjs reads session.js directly from node_modules/@web/test-runner-core/browser/session.js (which will resolve to version 1.0.0), whereas the test runner itself will execute using version 0.13.4. This mismatch can lead to runtime errors or unexpected behavior.

Please upgrade @web/test-runner and its associated plugins (like @web/test-runner-puppeteer) to versions that are compatible with @web/test-runner-core ^1.0.0 to ensure a single, unified version of the core runner is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: automation This PR is targeted to only merge into the branch defined in Github [bot use only]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant