This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(navbar): tabs not being read out by screen readers#9925
Merged
Conversation
crisbeto
added
a11y
Member
Author
ThomasBurleson
added
needs: presubmit
and removed
needs: review
* Fixes the tabs in the navbar not being read out by screen readers. This due to the fact that they were being highlighted as focused, but focus wasn't actually being passed to them. * Some minor cleanup in the navbar. Fixes angular#9383.
crisbeto
force-pushed
the
9383/navbar-a11y
branch
from
October 27, 2016 21:57
c541c07 to
f996310
Compare
kara
added
pr: merge ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9383.