Skip to content

fix(core): omit undefined search metadata - #38381

Closed
caddydove wants to merge 1 commit into
anomalyco:devfrom
caddydove:permission-metadata
Closed

caddydove wants to merge 1 commit into
anomalyco:devfrom
caddydove:permission-metadata

Conversation

@caddydove

Copy link
Copy Markdown

Fixes #37650

Only include provided optional search inputs in pending permission metadata, so the response remains JSON-encodable.

Validation: git diff --check

Not run: Bun is unavailable in this environment.

@github-actions github-actions Bot added the needs:compliance This means the issue will auto-close after 2 hours. label Jul 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Based on the search results, I found two potentially related PRs:

  1. PR fix(core): omit undefined optional keys from glob/grep permission metadata #37965 - fix(core): omit undefined optional keys from glob/grep permission metadata

  2. PR fix(core): drop undefined metadata values from permission requests #37679 - fix(core): drop undefined metadata values from permission requests

These PRs appear to be addressing the same underlying problem space (undefined values in permission metadata causing JSON encoding issues), though they may target different specific areas (glob/grep vs. search). You should verify whether PR #38381 duplicates or complements the fixes in these other PRs, or if they've already been merged/closed.

@caddydove caddydove closed this Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs:compliance This means the issue will auto-close after 2 hours.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tools: optional search metadata breaks pending permission listing

2 participants