fix(core): sanitize optional tool metadata on permission requests

[anujbolewar]

Omit undefined keys in glob/grep tool metadata construction and recursively sanitize metadata in permission request creation to prevent JSON schema encoding failures.

• Added recursive sanitizeValue/sanitizeMetadata helpers in permission.ts
• Updated glob.ts and grep.ts to conditionally spread optional fields
• Added test verifying undefined metadata properties are stripped
• Fixes tools: optional search metadata breaks pending permission listing #37650

[github-actions]

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

• PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

[github-actions]

The following comment was made by an LLM, it may be inaccurate:

I found several related PRs addressing similar issues with undefined metadata in permission requests:

Potential Duplicates:

1. PR fix(core): omit undefined optional keys from glob/grep permission metadata #37965 - fix(core): omit undefined optional keys from glob/grep permission metadata

   • fix(core): omit undefined optional keys from glob/grep permission metadata #37965
   • Directly addresses the same issue with glob/grep tool metadata

2. PR fix(core): drop undefined metadata values from permission requests #37679 - fix(core): drop undefined metadata values from permission requests

   • fix(core): drop undefined metadata values from permission requests #37679
   • Handles dropping undefined metadata values from permission requests

3. PR fix(opencode): drop undefined from v1 permission metadata #38918 - fix(opencode): drop undefined from v1 permission metadata

   • fix(opencode): drop undefined from v1 permission metadata #38918
   • Related fix for undefined permission metadata

All three PRs appear to be addressing the same root cause (undefined values in tool metadata causing JSON schema encoding failures). You should verify whether PR #40052 is a new attempt to address these issues or if it duplicates work already completed in one of these earlier PRs.

[github-actions]

This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window.

Feel free to open a new pull request that follows our guidelines.