fix(provider): parse URL-based provider IDs - #40071
obadakhalili wants to merge 3 commits into
Conversation
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
|
Can confirm as the original reporter that this does seem to fix the issue for me. Still trying to learn how to properly build and install from the branch to do more extensive testing but with |
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
|
This problem is still present in current versions. I'm still running a custom build of OC to be able to use the documented features of the project due to this bug. Please re-open this PR. |
Issue for this PR
Closes #39926
Type of change
What does this PR do?
parseModeldoes not account for models connected through a well-known gateway. It expectsproviderID/modelID, but fails when the provider ID is itself a URL. Normal prompts work because they send the provider and model IDs separately, while commands combine them into a single string that the server must parse.the PR fixes
parseModelto account for gateway-connected models.How did you verify your code works?
select the gateway model in
/modelssending a prompt works
before fix:
/gateway-testfails with "Model not found"after fix:
/gateway-testsucceedsChecklist