Skip to content

fix(core): coordinate websearch consent through service - #40883

Closed
opencode-agent[bot] wants to merge 1 commit into
v2from
websearch-consent-service
Closed

fix(core): coordinate websearch consent through service#40883
opencode-agent[bot] wants to merge 1 commit into
v2from
websearch-consent-service

Conversation

@opencode-agent

@opencode-agent opencode-agent Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a global WebSearchPreference service that owns the device-wide provider preference and its semaphore
  • have Location-scoped websearch instances share that global service instead of reading KV directly
  • serialize consent through the service so concurrent searches across Locations still produce one form without module-level state
  • retry each search after the shared selection and cover five concurrent calls with a regression test

This is the service-scoped alternative to #40869.

Checks

  • bun test test/tool-websearch.test.ts --only-failures (from packages/core)
  • GOMAXPROCS=2 bun typecheck (from packages/core)
  • bun run lint packages/core/src/websearch-preference.ts packages/core/src/tool/plugin/websearch.ts packages/core/src/plugin/internal.ts packages/core/test/tool-websearch.test.ts
  • Prettier check on changed implementation/test files
  • git diff --check

Requested by: @jlongster (James Long via Slack)

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant