Fixes #37650

[asiimhusain]

Issue for this PR

tools: optional search metadata breaks pending permission listing
#37650

Type of change

• Bug fix
• New feature
• Refactor / code improvement
• Documentation

What does this PR do?

When executing glob and grep tools without optional parameters, params.path and params.include are undefined. Previously, these were passed directly into the permission request metadata object (e.g., { pattern: "...", path: undefined, include: undefined }), leaving keys with undefined values that can cause schema encoding or serialization issues.

This PR fixes the issue by:

1. Conditionally adding path and include to permission request metadata only when defined in GlobTool (packages/opencode/src/tool/glob.ts) and GrepTool (packages/opencode/src/tool/grep.ts).
2. Filtering out any undefined metadata values in Permission.ask (packages/opencode/src/permission/index.ts) before building the permission request object.

How did you verify your code works?

Added unit tests to verify permission request metadata construction and schema encoding:

• packages/opencode/test/permission/next.test.ts: Verified permission requests omit undefined metadata properties and encode properly with Schema.encode(Schema.Array(PermissionV1.Request)).
• packages/opencode/test/tool/glob.test.ts: Verified GlobTool omits path key when not supplied and includes it when provided.
• packages/opencode/test/tool/grep.test.ts: Verified GrepTool omits path and include keys when not supplied and includes them when provided.

Screenshots / recordings

N/A (No UI changes)

Checklist

• I have tested my changes locally
• I have not included unrelated changes in this PR

[github-actions]

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

1. Open an issue describing the bug/feature (if one doesn't exist)
2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

[github-actions]

The following comment was made by an LLM, it may be inaccurate:

Potential Duplicate Found

PR #37965: fix(core): omit undefined optional keys from glob/grep permission metadata

• fix(core): omit undefined optional keys from glob/grep permission metadata #37965

This PR appears to be directly related to your current PR #41671. Both address the same issue: omitting undefined optional keys from glob/grep permission metadata. This could indicate that:

1. PR fix(core): omit undefined optional keys from glob/grep permission metadata #37965 may already address this issue in a different location (e.g., core vs opencode packages)
2. It may be a duplicate that needs consolidation
3. It may be a related but distinct fix in different parts of the codebase

Recommend checking PR #37965 to understand if it covers the same fixes or if they target different but related parts of the system.

[github-actions]

Hey! Your PR title Fixes #37650 doesn't follow conventional commit format.

Please update it to start with one of:

• feat: or feat(scope): new feature
• fix: or fix(scope): bug fix
• docs: or docs(scope): documentation changes
• chore: or chore(scope): maintenance tasks
• refactor: or refactor(scope): code refactoring
• test: or test(scope): adding or updating tests

Where scope is the package name (e.g., app, desktop, opencode).

See CONTRIBUTING.md for details.