fix(app): enable directory auto-accept settings - #42331
Draft
michaelbuckner wants to merge 1 commit into
Draft
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential related PRs found:
Note: These are related PRs addressing different aspects of the auto-accept feature, not exact duplicates. PR #42331 is a targeted bug fix for draft/directory-backed sessions, while #39328 handles the broader persistence and precedence changes. |
6 tasks
This was referenced Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #31137
Type of change
What does this PR do?
V2 Settings already receives a session ID for active sessions, but draft and directory-backed new-session routes have no session ID even though the layout knows their active directory. That leaves the auto-accept switch disabled in those routes.
This passes the active route directory into General Settings and uses the existing directory-scoped auto-accept API when there is no session ID. Existing session behavior is unchanged. Settings with no active directory remains disabled and sends no permission request.
This does not add a global default or change auto-accept persistence or precedence. #39328 proposes that broader behavior separately.
How did you verify your code works?
PLAYWRIGHT_WORKERS=1 bun run test:e2e e2e/regression/remote-session-settings.spec.ts --grep "draft settings use directory auto-accept|settings without active scope keep auto-accept disabled|session settings use the remote server context"— 3 passedbun run typecheck:e2e— passedbun run build— passedbun typecheckwith Bun 1.3.14 — 30/30 packages passedThe remote draft regression verifies the switch enables, toggles, and sends the permission request only to the correct server and directory. The no-active-scope regression verifies the switch remains disabled and sends no permission request.
Screenshots / recordings
No visual styling changes. The new Playwright coverage exercises the rendered Settings switch and its before/after enabled state; manual Chromium QA also covered 768×900 and 1280×720.
Before
After
Checklist