fix(console): preserve usage reset boundaries - #44729
Merged
Merged
Conversation
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
A usage write can wait on the database across a weekly or monthly reset boundary. Previously, the period was selected using application time while
time_*_updatedwas persisted with databasenow(). A write that selected the old period but executed after the boundary could therefore retain old usage and stamp it as current-period usage, preventing the next request from resetting the counter.The update now treats each fixed-window write as an event at one timestamp. It adds within that event's period, resets when advancing to a new period, and ignores delayed events when a newer period is already stored.
Checks
bun typecheck(packages/console/app)bun typecheck(packages/console/core)bun test test/subscription.test.ts(packages/console/core)bun x prettier --check packages/console/app/src/routes/zen/util/handler.tsgit diff --checkThe full Console app test suite has two pre-existing failures in
providerUsage.test.ts: Google normalized output tokens are currently5, while the tests expect3. The remaining five app tests pass.Requested by: @MrMushrooooom (Jack via Slack)