fix(app): drop archived sessions from home list right away - #44905
Merged
Conversation
github-actions
Bot
added
needs:compliance
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Brendonovich
enabled auto-merge (squash)
August 25, 2026 07:22
Anonymouse8882
pushed a commit
to Anonymouse8882/opencode
that referenced
this pull request
Aug 27, 2026
Archipel
pushed a commit
to Archipel/opencode
that referenced
this pull request
Aug 29, 2026
…#44905) Co-authored-by: Brendan Allan <14191578+Brendonovich@users.noreply.github.com>
1056674754
added a commit
to 1056674754/opencode
that referenced
this pull request
Aug 31, 2026
Upstream v1.18.23 (ef2880f, merged at 2091b86) -> v1.18.25 (cb7d8b2), 41 commits / 224 files. Upstream superseded the v1.18.24 release commit (57e8055) with 19db518 (sync release versions for v1.18.24) in the v1.18.25 lineage; merge base is 31c409a (update inference headers). Staged delta vs pre-merge fork HEAD is identical to the upstream tag-to-tag diff (224 files, +5428/-1627), confirming a clean adoption. Functional changes: - feat(opencode): load supported v2 config in v1 (anomalyco#45421) — new config/v2-compat.ts lowers v2 config onto v1 before schema parsing; decodeConfig wraps every load/update path. Fork's getFresh/commitFresh interface additions in config.ts untouched. - feat(opencode): support Azure CLI authentication (anomalyco#45079) and fix: remove Bun dependency from Azure authentication (anomalyco#45845) — plugin/azure.ts grows an az CLI credential chain (+241); provider.ts custom Azure loader adds auth.accountId as a resource-name fallback (1 line, disjoint from the fork snapshot architecture). New test/plugin/azure.test.ts passes in full. - fix(opencode): compare config snapshots as JSON (anomalyco#45784) — the update path re-reads the original file text and merges the patch onto the raw parsed record, detecting change via serialized comparison. - fix(provider): filter unreplayable Bedrock reasoning before caching (anomalyco#45769) — transform.ts; verified disjoint from the fork GLM/ZhiPu normalization block, which is intact. - fix(core): recover legacy database migration history (anomalyco#45061). - fix(ui): restore focus in stacked dialogs (anomalyco#44928); fix(app): drop archived sessions from home list right away (anomalyco#44905). - console/stats/go: zen quota usage breakdown, weekly retention metrics, Go comparison chart mobile fix, auth redirect validation, checkout rate limit; docs: Qwen3.8 Flash, GLM-5.3-Flash, Grok 4.6. Conflicts resolved: 29 package.json version bumps (rebranded 1.18.25-sscity), bun.lock (took upstream, rebranded workspace entries via bun install; only external dep delta is removal of the console map stack d3-geo/topojson/ world-atlas plus a @types/bun catalog entry). provider.ts and transform.ts auto-merged; merged files verified to differ from v1.18.25 only by fork deltas (ProviderSnapshot architecture, deferred snapshot initialization, GLM normalization, getFresh/commitFresh). Tests: provider 105, transform, bedrock, config, v2-compat, session retry/llm — 906 pass / 0 fail across 14 files; azure plugin 18 pass; typecheck clean. Pre-existing, not from this merge: 4 cf-ai-gateway-e2e anthropic-passthrough tests fail identically on pre-merge fork HEAD with an unchanged ai-gateway-provider 3.2.0 lock entry — environmental drift, left as-is. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #44619
Type of change
What does this PR do?
When a session is archived, it stayed visible in the Home list until a full refresh because the in-memory Home index cache was never updated.
This bug already existed before PR #41741 (register archive session command in both layouts), which re-enabled archiving . It was just hidden while archiving was broken. Restoring it brought the bug back.
This PR adds a
remove(sessionID)method to the Home index cache (home-session-index.ts), and call it right after archiving, both from Home (home-sessions-controller.tsx) and from the session route (session-archive.ts), so the archived session disappears from the Home list immediately.The remove call is a no-op when the Home index isn't mounted.
How did you verify your code works?
bun typecheck
Unit tests for home-session-index: removal of a session from the loaded index, and no-op when the index isn't mounted
Screenshots / recordings
Before
CleanShot.2026-08-25.at.08.48.18-converted.mp4
After
CleanShot.2026-08-25.at.08.52.15-converted.mp4
Checklist