feat(desktop): open existing sessions from deep links - #45103
Open
filantus wants to merge 2 commits into
Open
Conversation
|
I'd love to see this feature added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #44167
Type of change
What does this PR do?
Adds
opencode://open-session?server=...&session=...links for existing Desktop sessions. The app resolves the configured server plus canonical session lineage before navigating.Adds Copy link to the custom session-tab context menu introduced by #46116. It copies the public URL on Desktop and an absolute web URL in the browser, with localized success/error feedback.
Desktop forwards protocol URLs from both initial startup arguments and second-instance delivery. Deep-link handling is serialized so launches are processed in delivery order, while a single argument batch uses its last supported URL.
This complements #44137: that PR creates a new session from an external URL, while this one opens an existing Desktop session.
How did you verify your code works?
bun test --conditions=solid --preload ./happydom.ts ./src/pages/layout/helpers.test.tsfrompackages/app(33 passed)bun test ./src/main/deep-links.test.tsfrompackages/desktop(2 passed)bun run typecheckfrompackages/appandpackages/desktop(passed)bun turbo typecheckvia the pre-push hook after merging upstreamdev(30 tasks passed)Screenshots / recordings
The session-tab context menu now contains Rename, Copy link, and Close tab. No screenshot is attached.
Checklist