fix(desktop): separate unpackaged app identity - #46474
Open
CannonRS wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #46473
Type of change
What does this PR do?
Gives the unpackaged Electron desktop process its own Windows AppUserModelID instead of reusing the installed Dev application's identity.
The existing Dev user-data directory and every packaged channel ID remain unchanged. This prevents stale Electron shortcuts or pins from taking over the installed Dev taskbar group while preserving the taskbar identity setup introduced in #23368.
How did you verify your code works?
bun test src/main/app-identity.test.tsinpackages/desktop(2 passed)bun typecheckinpackages/desktopbun run buildinpackages/desktopScreenshots / recordings
N/A — this changes the native Windows process identity used for taskbar association; the regression test covers the packaged and unpackaged identity contract.
Checklist