fix(opencode): stop Azure model discovery from logging to stdout - #46646
Merged
Merged
Conversation
The provider models hook runs outside the app Effect runtime, so Effect.runSync(Effect.logWarning(...)) used the default console logger and printed a warning on every startup for users with an Azure oauth entry but no az CLI. Skip discovery when az is not installed and drop the console-bound log.
Defaulting available to true hid the exact dependency this fix gates on. Make every collaborator explicit and move the boilerplate into the tests.
filipeforattini
added a commit
to reddb-io/redcode
that referenced
this pull request
Sep 5, 2026
…malyco#46646) Ported from anomalyco/opencode 216ba8f. Upstream: 216ba8f
filipeforattini
added a commit
to reddb-io/redcode
that referenced
this pull request
Sep 5, 2026
…malyco#46646) Ported from anomalyco/opencode 216ba8f. Upstream: 216ba8f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Users with an Azure
oauthauth entry but without theazCLI installed saw an Azure warning printed to stdout on every startup.Two things were wrong in
packages/opencode/src/plugin/azure.ts:provider.modelshook is invoked throughEffect.promiseinprovider.ts, i.e. outside the app's Effect runtime. Its.catchcalledEffect.runSync(Effect.logWarning(...)), which spins up a bare runtime with the default console logger and writes straight to stdout.azeven whenwhich("az")had already determined the CLI was missing, guaranteeing the failure.Fix
azcommand is spawned when the CLI is unavailable.