refactor(tui): use OpenTUI Dynamic in session view - #46649
Merged
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Import the session view's
Dynamiccomponent from@opentui/solidrather thansolid-js/web. This keeps the terminal view on its renderer's implementation instead of selecting Solid Web's browser/server implementation through runtime conditions.One file, import change only. No new tests, dependencies, build settings, or dev-script changes.
Split out of #46644 so the renderer cleanup can be reviewed independently of the Bedrock dev-runtime fix. This is not required to fix Bedrock decoding. A primitive-level reproduction showed the server version does not react to component selection changes, but no user-visible session-view regression was established; the view selects function components from each part's type.
Verification
bun typecheckinpackages/tui: passed.bun test --timeout 30000 --only-failuresinpackages/tui: 193 passed, 1 skipped, 0 failed.git diff --check: passed.Checklist