test(opencode): fix session tools test typecheck and runtime - #46677
Merged
Conversation
daniel-liu-carsales
added a commit
to wellofspirit/opencode
that referenced
this pull request
Sep 7, 2026
Upstream's tools.test.ts (anomalyco#46677) builds a Permission fake that satisfies Permission.Interface. The hermetic-session patch adds `seal` to that interface, so the fake needs the extra member to typecheck.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
devtypecheck has been red since #32596 landed (https://github.com/anomalyco/opencode/actions?query=branch%3Adev+workflow%3Atypecheck). That PR was authored against an older API and its newtest/session/tools.test.tsno longer typechecks or runs against currentdev:SessionTools.resolvenow requiresRuntimeFlags.Service, which the test layer did not provideSession.Infogrew enough fields that the partialas Session.Infocast is rejected; needsas unknown asToolExecutionOptionsnow requiresmessagesresolvecallsmcp.clients(), which the fake MCP service did not implementChange
Test-only. Add
RuntimeFlags.layer()to the layer, stubclients()on the fake MCP, cast the partial session throughunknown, and passmessages: []toexecute.Verification
bun typecheckinpackages/opencode: 0 errorsbun test test/session/tools.test.ts: passessrc/session/tools.tsfix from fix(core): Fix for incorrect time.start reset in tool call logging (#32574) #32596 makes the test fail again, so it still guards the regression it was written for