Skip to content

fix(cli): bridge question forms over ACP - #46845

Closed
a12233 wants to merge 1 commit into
anomalyco:v2from
a12233:acp-question-bridge
Closed

fix(cli): bridge question forms over ACP#46845
a12233 wants to merge 1 commit into
anomalyco:v2from
a12233:acp-question-bridge

Conversation

@a12233

@a12233 a12233 commented Sep 2, 2026

Copy link
Copy Markdown

Summary

  • advertise the private OpenCode ACP elicitation capability during initialization
  • translate question-backed form.created events into session/elicitation requests
  • map accepted single-select, multiselect, and custom answers back through the V2 form reply API
  • cancel question forms when elicitation is unsupported or declined

Root cause

The V2 question tool emits form.created, but the ACP bridge treated all forms as unsupported and cancelled them. ACP clients therefore saw the question tool fail with The user dismissed this question and never received an elicitation request.

Testing

  • bun test test/acp/question.test.ts test/acp/event-behavior.test.ts
  • bun typecheck in packages/cli
  • repository pre-push bun turbo typecheck --concurrency=3 (33 packages)
  • manual ACP subprocess: observed session/elicitation, accepted q0: "Alpha", question tool completed, prompt returned end_turn

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions github-actions Bot added needs:compliance This means the issue will auto-close after 2 hours. needs:issue labels Sep 2, 2026
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Based on my search, I found one related PR that may be worth checking:

Related PR:

Note: I also found historical references (#42158, #20017) but these are older and likely already merged/closed.

The current PR (#46845) is the only open PR directly addressing the ACP question form bridging. No duplicate open PRs found for this specific feature.

@a12233

a12233 commented Sep 2, 2026

Copy link
Copy Markdown
Author

Closing this upstream PR; this integration is specific to a personal fork consumer and will be tracked in the fork instead.

@a12233 a12233 closed this Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs:compliance This means the issue will auto-close after 2 hours. needs:issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant