fix(cli): bridge question forms over ACP - #46845
Conversation
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found one related PR that may be worth checking: Related PR:
Note: I also found historical references (#42158, #20017) but these are older and likely already merged/closed. The current PR (#46845) is the only open PR directly addressing the ACP question form bridging. No duplicate open PRs found for this specific feature. |
|
Closing this upstream PR; this integration is specific to a personal fork consumer and will be tracked in the fork instead. |
Summary
form.createdevents intosession/elicitationrequestsRoot cause
The V2 question tool emits
form.created, but the ACP bridge treated all forms as unsupported and cancelled them. ACP clients therefore saw the question tool fail withThe user dismissed this questionand never received an elicitation request.Testing
bun test test/acp/question.test.ts test/acp/event-behavior.test.tsbun typecheckinpackages/clibun turbo typecheck --concurrency=3(33 packages)session/elicitation, acceptedq0: "Alpha", question tool completed, prompt returnedend_turn