Skip to content

fix(opencode): compare Codex GPT versions by major and minor - #47385

Merged
rekram1-node merged 2 commits into
devfrom
codex-version-comparison
Sep 4, 2026
Merged

fix(opencode): compare Codex GPT versions by major and minor#47385
rekram1-node merged 2 commits into
devfrom
codex-version-comparison

Conversation

@rekram1-node

@rekram1-node rekram1-node commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Issue for this PR

Follow-up to #47384.

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Parses GPT major/minor versions separately and checks major > 5 || (major === 5 && minor > 4). An omitted minor version is zero. This allows versions such as 5.10 that parseFloat incorrectly treated as 5.1.

Only extracts the version prefix; it does not validate model suffixes. Existing explicit subscription allow/deny rules are unchanged. V2 is untouched.

How did you verify your code works?

  • Reproduced the multi-digit minor-version failures before the fix.
  • Added coverage confirming suffixes do not cause newer models to be filtered out, including gpt-6..
  • bun test test/plugin/codex.test.ts --timeout 30000: 45 passed.
  • bun typecheck: passed in packages/opencode.
  • Prettier and git diff --check: passed.

Screenshots / recordings

Not applicable.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@rekram1-node
rekram1-node merged commit 02a167e into dev Sep 4, 2026
10 checks passed
@rekram1-node
rekram1-node deleted the codex-version-comparison branch September 4, 2026 23:22
filipeforattini added a commit to reddb-io/redcode that referenced this pull request Sep 5, 2026
filipeforattini added a commit to reddb-io/redcode that referenced this pull request Sep 5, 2026
1056674754 added a commit to 1056674754/opencode that referenced this pull request Sep 7, 2026
Upstream v1.18.27 (4b7e19e, merged at 26dff3f) -> v1.18.29 (1674747),
29 commits / 116 files. Merge base is b046973 (default header timeout to
five minutes). Staged delta vs pre-merge fork HEAD is identical to the
upstream tag-to-tag diff, confirming a clean adoption.

Functional changes:
- fix(opencode): compare Codex GPT versions by major and minor (anomalyco#47385) and
  allow integer GPT versions in the Codex model filter (anomalyco#47384) — codex.ts;
  disjoint from fork snapshot architecture, auto-merged.
- feat(copilot): send X-Interaction-Id header with session id (anomalyco#47215) —
  github-copilot/copilot.ts, 1 line.
- chore: bump gitlab-ai-provider to 6.13.0 (anomalyco#46914).
- test(core): disable npm audits in the test preload (anomalyco#47222).
- console: limits graph, i18n for ar/br/da/de/es/fr/it/ja + others;
  app: dialog-connect-provider and open-in-app-v2 fixes; go.mdx crawl rules
  gain the x-opencode-session header bullet (took upstream whole).

Conflicts resolved: 29 package.json version bumps (rebranded 1.18.29-sscity;
HEAD had moved to the local v1.18.27 merge meanwhile), bun.lock (took
upstream, rebranded workspace entries via bun install), go.mdx (took
upstream — trivial <br/> placement in the crawl-rules list). Fork deltas
verified intact vs v1.18.29: provider ProviderSnapshot architecture,
deferred snapshot init, GLM/ZhiPu normalization in transform.ts (+77 lines
fork-only), config getFresh/commitFresh. Tests: provider, transform, config,
v2, azure plugin, session retry/llm — 1036 pass / 0 fail across 14 files;
typecheck clean.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
arbocdi pushed a commit to arbocdi/opencode that referenced this pull request Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant