Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found two PRs that are potentially related to this fix:
These PRs address similar concerns around URL path prefixes and proxy deployments, but PR #47442 appears to be focused specifically on the client-side fix to preserve those prefixes correctly when connecting through a proxy path like The other health check and connection-related PRs found are not directly related to the URL path prefix preservation issue. |
|
@jlongster I've put the fix for #46498 here. The local HTTP/SSE and CLI regressions pass, including the direct The issue check looks like a false positive: the description already has Could you link the issue and clear |
Keep the upstream SSE activity callback alongside prefix-aware URL construction, then regenerate the Promise client.
|
Merged the latest Rechecked with Bun 1.4.2: 166 client tests, 94 generator tests, 12 CLI tests, and all 33 pre-push typechecks pass. The diff against |
|
Synced v2 in 916949b to pick up the On that commit, 165 client tests, 96 generator tests, and 12 CLI tests pass (273 total). The three package typechecks and all 35 pre-push typechecks pass too. The diff against the synced v2 base is still limited to the original 10 files. |
Issue for this PR
Closes #46498
Type of change
What does this PR do?
Connecting to
http://host/proxycurrently sends requests to/api/...instead of/proxy/api/.... The health check fails before the client can connect.Resolve API paths relative to the configured server path, with or without a trailing slash. The fix includes the Promise client generator, terminal WebSocket URLs, and the direct requests in
apiandimport, so those keep working after the health check succeeds.How did you verify your code works?
/proxy, trailing slashes, nested paths, query parameters, and authentication headers. The four prefixed cases still fail on the upstream-only generator.v2at33f48f36c, with Bun 1.4.2: client suite 166 passed, code generator suite 94 passed, focused CLI tests 12 passed. This includes the upstream SSE activity callback test.bun run generate; a second run produces no changes. Typechecks pass in all three affected packages and all 33 repository pre-push tasks.Screenshots / recordings
Not applicable.
Checklist