feat(app): pulse the status dot while the event stream reconnects - #47574
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the event stream is connecting or reconnecting, nothing in the UI shows it. With the stall detection in #47571 a phone that wakes from sleep now reconnects and resyncs on its own, but for that second or two the page looks frozen with a green dot.
connection.status() !== "connected"and gainsanimate-pulse, so it visibly breathes while waiting on the server.ready,attention,issue) are unchanged once the stream is connected.Both clips: stream healthy → event stream cut for ~5 s (server still answering
/api/health) → stream restored.Before — the dot stays solid green while the stream is dead:
before.mp4
After — the dot turns neutral and pulses until the stream reconnects:
after.mp4